WebViewLayoutTest#testMediaStreamApi consistently timing out |
||||
Issue description
,
Sep 7 2016
mcasas@, do you think https://codereview.chromium.org/2286303003 might be the culprit? It's the only change in the range that looks at all related. I can't make a causal connection though, so I'm not going to revert it yet unless you see a reason it might cause this failure. I'm currently trying to repro the failure locally.
,
Sep 7 2016
Hmm I don't see exactly how my CL could break just that particular bot, perhaps it's the v8 or the Blink rolls? If you can't find a culprit feel free to revert mine, I can re-land it if it's not guilty.
,
Sep 7 2016
Almost certainly related failure: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/6674 org.chromium.android_webview.test.MediaAccessPermissionRequestTest#testGrantAccess timing out Regression range on that one is strictly wider though so that doesn't help narrow down.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc commit da52a637d5ce09e9d0991b9d4d0238c195eb8ddc Author: aelias <aelias@chromium.org> Date: Thu Sep 08 01:28:10 2016 Revert of Video capture Android: enable unittests for Camera2 API (patchset #5 id:220001 of https://codereview.chromium.org/2286303003/ ) Reason for revert: Caused WebViewLayoutTest#testMediaStreamApi and MediaAccessPermissionRequestTest#testGrantAccess to consistently fail. Confirmed locally by reverting patch, commenting out @DisableIf and running: ninja -C out/Release android_webview_test_apk android_webview_apk && out/Release/bin/run_android_webview_test_apk -f MediaAccessPermissionRequestTest.* BUG= 644910 Original issue's description: > Video capture Android: enable unittests for Camera2 API > > This CL reenables a bunch of VideoCaptureDeviceTest > test cases for Android and for the "new" APIs > > For this: > - adds a |mTestMode| to VideoCapture.java, interface > of all camera java classes. VCCamera2.java tests this > flag and adds a capture thread if it's set. > - the C++ correspondent classes get a method to configure > the java side for testing, and a method to test if the > underlying platform is using the new or the old APIs. > > Also: > - Removes DeAllocateCameraWhileRunning because it was > equivalent to CaptureWithSize test case. > - Cleans up/refactors some parts of the unit tests, adds > a few more comments etc > > BUG=626857 > > Committed: https://crrev.com/7c32b70068c65b7bb372bb52a33d70b8e6653129 > Cr-Commit-Position: refs/heads/master@{#417015} TBR=jbudorick@chromium.org,emircan@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626857 Review-Url: https://codereview.chromium.org/2320873002 Cr-Commit-Position: refs/heads/master@{#417147} [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/java/src/org/chromium/media/VideoCapture.java [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/java/src/org/chromium/media/VideoCaptureFactory.java [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_android.cc [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_android.h [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_factory_android.cc [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_factory_android.h [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/video_capture_device_unittest.cc
,
Sep 8 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc commit da52a637d5ce09e9d0991b9d4d0238c195eb8ddc Author: aelias <aelias@chromium.org> Date: Thu Sep 08 01:28:10 2016 Revert of Video capture Android: enable unittests for Camera2 API (patchset #5 id:220001 of https://codereview.chromium.org/2286303003/ ) Reason for revert: Caused WebViewLayoutTest#testMediaStreamApi and MediaAccessPermissionRequestTest#testGrantAccess to consistently fail. Confirmed locally by reverting patch, commenting out @DisableIf and running: ninja -C out/Release android_webview_test_apk android_webview_apk && out/Release/bin/run_android_webview_test_apk -f MediaAccessPermissionRequestTest.* BUG= 644910 Original issue's description: > Video capture Android: enable unittests for Camera2 API > > This CL reenables a bunch of VideoCaptureDeviceTest > test cases for Android and for the "new" APIs > > For this: > - adds a |mTestMode| to VideoCapture.java, interface > of all camera java classes. VCCamera2.java tests this > flag and adds a capture thread if it's set. > - the C++ correspondent classes get a method to configure > the java side for testing, and a method to test if the > underlying platform is using the new or the old APIs. > > Also: > - Removes DeAllocateCameraWhileRunning because it was > equivalent to CaptureWithSize test case. > - Cleans up/refactors some parts of the unit tests, adds > a few more comments etc > > BUG=626857 > > Committed: https://crrev.com/7c32b70068c65b7bb372bb52a33d70b8e6653129 > Cr-Commit-Position: refs/heads/master@{#417015} TBR=jbudorick@chromium.org,emircan@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626857 Review-Url: https://codereview.chromium.org/2320873002 Cr-Commit-Position: refs/heads/master@{#417147} [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/java/src/org/chromium/media/VideoCapture.java [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/java/src/org/chromium/media/VideoCaptureFactory.java [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_android.cc [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_android.h [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_factory_android.cc [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/android/video_capture_device_factory_android.h [modify] https://crrev.com/da52a637d5ce09e9d0991b9d4d0238c195eb8ddc/media/capture/video/video_capture_device_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by aelias@chromium.org
, Sep 7 2016