Desktop Capture Picker Window Title Used Sentence Case |
|||||||
Issue descriptionOn Mac the picker window's title "Share your screen" uses sentence case.
,
Sep 8 2016
,
Sep 13 2016
,
Sep 13 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27aa95f6074ba1d8ebc74ec92d50df8b53b99d13 commit 27aa95f6074ba1d8ebc74ec92d50df8b53b99d13 Author: qiangchen <qiangchen@chromium.org> Date: Tue Sep 13 20:48:47 2016 Bug Fix: Title Case for Picker Window Title On Mac, desktop capture picker window's title is using sentence case, but by convention, it should be in title case. This CL Fixes the bug. BUG= 644905 TBR=msw@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2319303002 Cr-Commit-Position: refs/heads/master@{#417422} (cherry picked from commit f8b6ed629f6adaa2bcb7969bc586f117994b137d) Review-Url: https://codereview.chromium.org/2334283003 Cr-Commit-Position: refs/branch-heads/2840@{#339} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/27aa95f6074ba1d8ebc74ec92d50df8b53b99d13/chrome/app/generated_resources.grd
,
Sep 14 2016
@quangche: Are there any manual steps to verify the above change ?
,
Sep 14 2016
Not blocking M54 release, planning to verify if manual testing is feasible.
,
Sep 14 2016
Run desktop share on Mac by whatever means. Look at the title of the picker window. It should be "Share Your Screen" not "Share your screen". The only difference is the letter case.
,
Sep 14 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27aa95f6074ba1d8ebc74ec92d50df8b53b99d13 commit 27aa95f6074ba1d8ebc74ec92d50df8b53b99d13 Author: qiangchen <qiangchen@chromium.org> Date: Tue Sep 13 20:48:47 2016 Bug Fix: Title Case for Picker Window Title On Mac, desktop capture picker window's title is using sentence case, but by convention, it should be in title case. This CL Fixes the bug. BUG= 644905 TBR=msw@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2319303002 Cr-Commit-Position: refs/heads/master@{#417422} (cherry picked from commit f8b6ed629f6adaa2bcb7969bc586f117994b137d) Review-Url: https://codereview.chromium.org/2334283003 Cr-Commit-Position: refs/branch-heads/2840@{#339} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/27aa95f6074ba1d8ebc74ec92d50df8b53b99d13/chrome/app/generated_resources.grd |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Sep 8 2016