New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644892 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Predator] run.sh can't handle symlinked directories

Project Member Reported by wrengr@chromium.org, Sep 7 2016

Issue description

When trying to run the unit tests for Findit from a symlinked directory, Python crashes with a very unhelpful error message. We should catch the OSError and either give a useful/legible/actionable error message or else just do the right thing to avoid the OSError in the first place.


$> ls -l findit-crash
lrwxrwxrwx 1 wrengr eng 36 Sep  1 08:20 findit-crash -> chromium-srcs/infra/appengine/findit
$> cd findit-crash
$> ./util_scripts/run.sh test
Traceback (most recent call last):
  File "/usr/local/google/home/wrengr/findit-crash/util_scripts/../../../test.py", line 127, in <module>
    [python_bin, os.path.join('bootstrap', 'remove_orphaned_pycs.py')])
  File "/usr/lib/python2.7/subprocess.py", line 535, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

 
Cc: kateso...@chromium.org mbarbe...@chromium.org st...@chromium.org infe...@chromium.org
Summary: [Findit] run.sh can't handle symlinked directories (was: Inscrutable Python error when trying to run unit tests)

Comment 2 by st...@chromium.org, Apr 24 2017

Components: -Tools>Test>FindIt Tools>Test>Predator
Status: Available (was: Untriaged)
Summary: [Predator] run.sh can't handle symlinked directories (was: [Findit] run.sh can't handle symlinked directories)
For Findit, we won't fix this, because none needs this support so far in the team.

After the separation of Predator from Findit, the run.sh there could be improved to address this if needed.
Status: Archived (was: Available)

Sign in to add a comment