New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644865 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment

Bisect not working for certain metrics affecting PCV2

Project Member Reported by robert...@chromium.org, Sep 7 2016

Issue description

https://github.com/catapult-project/catapult/issues/2778

Ethan is working on a fix for this on catapult. Filing this mostly to block affected perf regression bugs on.
 
Blocking: 643638
Blocking: 643637
Blocking: 643252
Blocking: 642061
Blocking: 643196
Blocking: 647629
Labels: -Pri-2 Pri-1
Hey Ethan, Is there any update on this?
Wrote a comment on the GitHub issue; I have a fix that turned out to be not quite correct but has a complement on the bisect side that will make it work. I'll implement it early next week which should fix this issue.
Blocking: 648649
Blocking: 648609
Blocking: 648602
Blocking: 648599
Blocking: 648424
Blocking: 647642
Blocking: 647628
Blocking: 647616
Blocking: 647615
Blocking: 647605
Blocking: 647603
Blocking: 647601
Blocking: 647360
Blocking: 646915
Blocking: 646913
Blocking: 646856
Blocking: 646141
Blocking: 645978
Blocking: 645974
Blocking: 645595
Blocking: 645592
Blocking: 645587
Blocking: 645585
Blocking: 645584
Blocking: 645580
Blocking: 645572
Blocking: 645567
Blocking: 645564
Blocking: 645562
Blocking: 645554
Blocking: 645552
Blocking: 645476
Blocking: 645376
Blocking: 645362
Blocking: 643187
Blocking: 643198
Blocking: 643202
Blocking: 643204
Blocking: 643773
Blocking: 645306
Blocking: 645307
Blocking: 645315
Blocking: 641495
Blocking: 641984
Blocking: 641986
Blocking: 641998
Blocking: 641999
Blocking: 642099
Blocking: 648653
Blocking: 648616
Project Member

Comment 60 by bugdroid1@chromium.org, Sep 20 2016

Project Member

Comment 61 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fbd04e06a34b13dc9659927efb4a19d6a978a9b

commit 1fbd04e06a34b13dc9659927efb4a19d6a978a9b
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 20 22:58:18 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cee7475ca3ab8eba9c9760cdf086cc7c703df15c [Bisect] Account for tir_label-level summaries in parse_metric (eakuefner@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 644865 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354113002
Cr-Commit-Position: refs/heads/master@{#419883}

[modify] https://crrev.com/1fbd04e06a34b13dc9659927efb4a19d6a978a9b/infra/config/recipes.cfg

Project Member

Comment 62 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/db8d44b26c5caaa7105b87e3c36abd876841f4de

commit db8d44b26c5caaa7105b87e3c36abd876841f4de
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Sep 20 23:05:53 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9672983b7e4143ea26754935e0132a0838f2b326 Add flutter_services (abarth@chromium.org)
  https://crrev.com/cee7475ca3ab8eba9c9760cdf086cc7c703df15c [Bisect] Account for tir_label-level summaries in parse_metric (eakuefner@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 644865 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2356043002

[modify] https://crrev.com/db8d44b26c5caaa7105b87e3c36abd876841f4de/infra/config/recipes.cfg

Blocking: 648884
Blocking: 648886
Blocking: 648893
I pushed Ethan's changes live to the dashboard and kicked off https://chromeperf.appspot.com/buildbucket_job_status/9000900884809620160.
Also kicked https://chromeperf.appspot.com/buildbucket_job_status/9000922468572912368 on Windows which may complete a little faster. I lowered the repeat count as well so we can get some quick feedback about whether this fix works.
Status: Started (was: Untriaged)
Whoops, I accidentally kicked it from the default version, so mine failed. We're still waiting on the one Annie kicked above to come back, which should hopefully be soon. Once that happens I can go through the deployment checklist and set as default, as long as the fix works.

It's promising that timeToFirstContentfulPaint_avg/pcv1-cold/http___jugem.jp_ is the metric being analyzed, which should work fine for bisect.
Something is off about Annie's bisect -- it seems that the performance test is hung. However, it passed the "Get Reference Values" step, which is where my faulty bisect stopped, so it seems like my fix works.

Annie, can you set the version you deployed this morning as default?
We've been having oom issues on all recent deployments of the Dashboard, which we believe just got fixed. Current default version is tot as of about an hour ago. 
Okay, the version with the fix should be the default now. I saw Kari kicked off some bisects yesterday, I will kick off more.
Blocking: -643638
Blocking: 643638
Issue 643638 has been merged into this issue.
Issue 643637 has been merged into this issue.
Status: Fixed (was: Started)
As bug triager, I've made sure that each bug that blocks on this one has had bisects re-kicked since the outage was resolved.

This bug can be closed.
Blocking: -645580
Components: Speed>Bisection

Sign in to add a comment