New issue
Advanced search Search tips

Issue 644860 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 631526
issue 645996

Blocking:
issue 615552



Sign in to add a comment

Port SystemModalContainerLayoutManager to mash

Project Member Reported by sky@chromium.org, Sep 7 2016

Issue description

Looks like it depends upon keyboard, which may need to be ported first.
 

Comment 1 by sky@chromium.org, Sep 7 2016

Blocking: 615552

Comment 2 by sky@chromium.org, Sep 7 2016

Blockedon: 631526

Comment 3 by sky@chromium.org, Sep 12 2016

Blockedon: 645996
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb

commit ea4ca940a5939c6f389b37594f8eb0b9ad0673fb
Author: sky <sky@chromium.org>
Date: Mon Sep 12 21:56:19 2016

Ports SystemModalContainerLayoutManager to ash/common

BUG= 644860 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2336653002
Cr-Commit-Position: refs/heads/master@{#418068}

[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/BUILD.gn
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm/container_finder.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm/container_finder.h
[add] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm/system_modal_container_layout_manager.cc
[add] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm/system_modal_container_layout_manager.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm_root_window_controller.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm_shell.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm_shell.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/common/wm_window_property.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/display/screen_position_controller.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/root_window_controller.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/root_window_controller.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/shell.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/shell.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/wm/screen_dimmer.cc
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/wm/screen_dimmer.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/wm/screen_pinning_controller.cc
[delete] https://crrev.com/37fe7f5ad68ac9e5111f150e2c593b9ffebe2be6/ash/wm/system_modal_container_layout_manager.cc
[delete] https://crrev.com/37fe7f5ad68ac9e5111f150e2c593b9ffebe2be6/ash/wm/system_modal_container_layout_manager.h
[modify] https://crrev.com/ea4ca940a5939c6f389b37594f8eb0b9ad0673fb/ash/wm/system_modal_container_layout_manager_unittest.cc

Comment 5 by sky@chromium.org, Mar 7 2017

Status: Fixed (was: Started)
Because of migrating to aura mash now uses SystemModalContainerLayoutManager.

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment