New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644855 link

Starred by 1 user
Status: Verified
Owner:
█ dfalcant...@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
rouslan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Payment dialog should cancel when Clank receives an external intent to navigate, or the tab closes, or whatever

Project Member Reported by dfalcant...@chromium.org, Sep 7 2016 
Version: Clank ToT, M54

Video of external intent: https://drive.google.com/open?id=0B7c8ZkXVwskDZ0ZIeVNxNk4yQUU

Probably not super-important to get fixed for M54, but it is likely occurring there, as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40db87010a9c66e974200ddfe5b5ca4f70cb130d

commit 40db87010a9c66e974200ddfe5b5ca4f70cb130d
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu Sep 08 22:07:53 2016

[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG= 644855 ,629071

Review-Url: https://codereview.chromium.org/2320063003
Cr-Commit-Position: refs/heads/master@{#417414}

[modify] https://crrev.com/40db87010a9c66e974200ddfe5b5ca4f70cb130d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/40db87010a9c66e974200ddfe5b5ca4f70cb130d/chrome/android/java_sources.gni
[add] https://crrev.com/40db87010a9c66e974200ddfe5b5ca4f70cb130d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java

Comment 2 by dfalcant...@chromium.org, Sep 8 2016

Status: Started (was: Assigned)
Don't know if this is worth cherry-picking.  Rouslan, WDYT?

Comment 3 by rouslan@chromium.org, Sep 8 2016

Labels: Merge-Request-54
Let's cherry pick. It's only ~130 lines that provide much better polish, which our users will appreciate.

Comment 4 by dimu@chromium.org, Sep 8 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 9 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c

commit 4885e92a2d0d43b746c5b39a12aa8d05e49fae6c
Author: dfalcantara@chromium.org <dfalcantara@chromium.org>
Date: Fri Sep 09 00:41:53 2016

[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG= 644855 ,629071
TBR=rouslan@chromium.org

Original Review-Url: https://codereview.chromium.org/2320063003

Review URL: https://codereview.chromium.org/2326783004 .

Cr-Commit-Position: refs/branch-heads/2840@{#259}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c/chrome/android/java_sources.gni
[add] https://crrev.com/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java

Comment 6 by dfalcant...@chromium.org, Sep 9 2016

Status: Fixed (was: Started)

Comment 7 by krav...@chromium.org, Sep 13 2016

Status: Verified (was: Fixed)
Verified in M54-54.0.2840.25
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c

commit 4885e92a2d0d43b746c5b39a12aa8d05e49fae6c
Author: dfalcantara@chromium.org <dfalcantara@chromium.org>
Date: Fri Sep 09 00:41:53 2016

[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG= 644855 ,629071
TBR=rouslan@chromium.org

Original Review-Url: https://codereview.chromium.org/2320063003

Review URL: https://codereview.chromium.org/2326783004 .

Cr-Commit-Position: refs/branch-heads/2840@{#259}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c/chrome/android/java_sources.gni
[add] https://crrev.com/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java

Comment 9 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment