DCHECK in background_downloader_win hit after a few minutes |
|||||
Issue descriptionVersion: Last seen in 55.0.2853.0 (Developer Build) (64-bit) OS: Windows 10 1. Launch a debug build 2. Wait a few minutes 3. DCHECK hit and browser crashes. See attached screenshot for trace I hit this a lot and it means I can't leave my debug builds running over lunch, for example.
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1210527860aafd4b24f0b91b9934ed19eac4aac commit c1210527860aafd4b24f0b91b9934ed19eac4aac Author: sorin <sorin@chromium.org> Date: Wed Sep 07 22:42:02 2016 Remove DCHECK from the component updater background downloader code. The threading issue needs to be fixed according to crbug.com/644857 R=waffles BUG= 644854 Review-Url: https://codereview.chromium.org/2322733002 Cr-Commit-Position: refs/heads/master@{#417103} [modify] https://crrev.com/c1210527860aafd4b24f0b91b9934ed19eac4aac/components/update_client/background_downloader_win.cc
,
Sep 7 2016
,
Sep 13 2016
,
Sep 13 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e7ddd7ae28dd2947d4a8f10e3788a5341e8871 commit 52e7ddd7ae28dd2947d4a8f10e3788a5341e8871 Author: Sorin Jianu <sorin@chromium.org> Date: Tue Sep 13 23:42:25 2016 Remove DCHECK from the component updater background downloader code. The threading issue needs to be fixed according to crbug.com/644857 R=waffles BUG= 644854 Review-Url: https://codereview.chromium.org/2322733002 Cr-Commit-Position: refs/heads/master@{#417103} (cherry picked from commit c1210527860aafd4b24f0b91b9934ed19eac4aac) Review URL: https://codereview.chromium.org/2339033002 . Cr-Commit-Position: refs/branch-heads/2840@{#347} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/52e7ddd7ae28dd2947d4a8f10e3788a5341e8871/components/update_client/background_downloader_win.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e7ddd7ae28dd2947d4a8f10e3788a5341e8871 commit 52e7ddd7ae28dd2947d4a8f10e3788a5341e8871 Author: Sorin Jianu <sorin@chromium.org> Date: Tue Sep 13 23:42:25 2016 Remove DCHECK from the component updater background downloader code. The threading issue needs to be fixed according to crbug.com/644857 R=waffles BUG= 644854 Review-Url: https://codereview.chromium.org/2322733002 Cr-Commit-Position: refs/heads/master@{#417103} (cherry picked from commit c1210527860aafd4b24f0b91b9934ed19eac4aac) Review URL: https://codereview.chromium.org/2339033002 . Cr-Commit-Position: refs/branch-heads/2840@{#347} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/52e7ddd7ae28dd2947d4a8f10e3788a5341e8871/components/update_client/background_downloader_win.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sorin@chromium.org
, Sep 7 2016Components: Internals>Installer>Components
Labels: -Pri-3 Pri-1
Status: Started (was: Untriaged)