Desktop Capture Picker Window Description Typo |
|||||
Issue descriptionIt displays "[Extension Name] wants to share the content of your screen with [URL]" for the call on the website. It displays "[Extension Name] wants to share the contents of your screen." for standalone app. Note: one uses singular form "content", the other uses plural form "contents".
,
Sep 7 2016
,
Sep 8 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 8 2016
Could you please confirm whether this change is baked/verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) so that we could take this for next Beta Release.
,
Sep 8 2016
Yes. It is just a string text change.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69519fe51ef874ae60fb903fec4cd10d37fe3387 commit 69519fe51ef874ae60fb903fec4cd10d37fe3387 Author: qiangchen <qiangchen@chromium.org> Date: Thu Sep 08 22:47:52 2016 Bug Fix: Desktop Capture Picker Window We used "[Extension] is sharing the content of your screen ...", and we should use plural form for "content". This CL fixes the bug. BUG= 644852 NOPRESUBMIT=TRUE NOTRY=TRUE TBR=msw@chromium.org Review-Url: https://codereview.chromium.org/2319163002 Cr-Commit-Position: refs/heads/master@{#417096} (cherry picked from commit 6a10e6934adc8c8aeb9325c5d996fca559c9b098) Review-Url: https://codereview.chromium.org/2327593003 Cr-Commit-Position: refs/branch-heads/2840@{#255} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/69519fe51ef874ae60fb903fec4cd10d37fe3387/chrome/app/generated_resources.grd
,
Sep 14 2016
@qiangchen: Could you please provide us the Steps to reproduce to verify this issue from TE side. Thank you.
,
Sep 14 2016
Run desktop share in what ever means. Look at the statement on the picker window, it should be "[Extension] is sharing the contents of your screen ..." not "[Extension] is sharing the content of your screen ..." Just a minor difference.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69519fe51ef874ae60fb903fec4cd10d37fe3387 commit 69519fe51ef874ae60fb903fec4cd10d37fe3387 Author: qiangchen <qiangchen@chromium.org> Date: Thu Sep 08 22:47:52 2016 Bug Fix: Desktop Capture Picker Window We used "[Extension] is sharing the content of your screen ...", and we should use plural form for "content". This CL fixes the bug. BUG= 644852 NOPRESUBMIT=TRUE NOTRY=TRUE TBR=msw@chromium.org Review-Url: https://codereview.chromium.org/2319163002 Cr-Commit-Position: refs/heads/master@{#417096} (cherry picked from commit 6a10e6934adc8c8aeb9325c5d996fca559c9b098) Review-Url: https://codereview.chromium.org/2327593003 Cr-Commit-Position: refs/branch-heads/2840@{#255} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/69519fe51ef874ae60fb903fec4cd10d37fe3387/chrome/app/generated_resources.grd |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2016