I've been struggling to get Alan to answer the question whether all dialogs are supposed to have blue buttons. (If so, I'm pretty sure we never use "default" styling.)

I don't think he's going to respond to this thread (it sounds like he diverts all of his crbug e-mails to a mailbox he never reads).

The sticker sheet and spec only show Primary and Secondary style buttons, so either a button is Primary (blue) or Secondary (white). Is "default" style a Material Design thing?

Right now any blue button in a dialog fires its action when the Return key is pressed. That is a Primary button in Harmony, so all currently blue buttons should continue to be blue Primary buttons.

I pinged him twice on the spreadsheet about dialogs in addition to at least two bugs.

The spec sheet has columns for Selected, Default, Disabled, Normal, etc. [1] Granted, the default is not grey (that's from an old design), but I'm loathe to implement it when I think it probably doesn't need to ever exist.

> Right now any blue button in a dialog fires its action when the Return key is pressed...

Yes, some pre-harmony dialogs (not all, and not the bookmark bubble) use blue buttons for the default button. This is why we have ShouldDefaultButtonBeBlue. I hope that we can just assume the answer is always yes. (I don't know what mac does. Maybe mac always uses blue buttons already.)

[1] https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-01a-buttons-light-theme.png%3Fz=width

Yes, Mac default buttons are always blue. I assumed that default buttons elsewhere are blue. And now I see what you're saying about the spec. It seems that rather than say a Primary button means it's the default, they are saying there can be Primary buttons that are the default (or not) and secondary buttons that are the default. That does not make any sense to me. I will try to get some clarification from bettes@.

I'm going to talk to bettes@ about default buttons always being blue, but regardless of the answer, the button in the screenshot should not be gray. According to the Harmony spec, a button will either be blue or white filled.

according to the spec, "default" looks like "hovered", not white. I am not planning on implementing that unless I know that default has a use.

Correct, default looks like not white, but it does not look like the dark gray you're currently using.

no one has claimed that the current dark grey is correct. It's impossible to fix it until we know what is correct though.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1713992c55069cc914715dac18356a3eef774b8e

commit 1713992c55069cc914715dac18356a3eef774b8e
Author: estade <estade@chromium.org>
Date: Thu Sep 22 22:54:26 2016

MdTextButton: get rid of distinct "default" styling and make all
default dialog buttons blue.

BUG= 644849 

Review-Url: https://codereview.chromium.org/2361063002
Cr-Commit-Position: refs/heads/master@{#420488}

[modify] https://crrev.com/1713992c55069cc914715dac18356a3eef774b8e/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/1713992c55069cc914715dac18356a3eef774b8e/ui/views/window/dialog_client_view.cc

Tested the same on win10 chrome version 55.0.2873.0 with secondary-ui-md enabled in chrome://flags - Observed that the buttons appear blue as expected.

Please find the screnshot

Deleted: 644849.png 93.6 KB

	644849.png 93.6 KB View Download