New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644848 link

Starred by 1 user
Status: Fixed
Owner:
█ dfalcant...@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
tedc...@chromium.org
█ k...@chromium.org
█ dfalcant...@chromium.org
█ rolfe@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove "Open in Chrome" menu item from help pages and other things using the EmbedContentViewActivity

Project Member Reported by dfalcant...@chromium.org, Sep 7 2016 
Rebecca: would UX have strong objections to removing the "open in chrome" item in this mini-Activity?  The Activity is generally used to show web pages when the Clank browser shouldn't be displaying the tab, like a help page for a dialog that's on top of the browser, or when the user is still going through First Run and is (gasp) reading the Terms of Service and can't be sent to Chrome yet.

Neither Ted or I can figure out why the menu was first added, and can't determine if it adds any value.  One benefit of it includes closing a class of bugs that involve navigating to rarely used internal help pages and putting Chrome in a bad state.
screenshot-018e010b20c96fd2-20160907T132556.png
263 KB View Download
screenshot-018e010b20c96fd2-20160907T132621.png
257 KB View Download
screenshot-018e010b20c96fd2-20160907T133309.png
192 KB View Download

Comment 1 by rolfe@chromium.org, Sep 8 2016 

I'm OK closing it if it streamlines things! Guessing there's no metrics on it so suppose we should just keep an eye out in the feedback threads if there's any issue with removal.

Comment 2 by dfalcant...@chromium.org, Sep 8 2016

Cc: rolfe@chromium.org
Owner: dfalcant...@chromium.org
Status: Started (was: Assigned)
Cool, thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5407ae12413f9dd3edc4b4a4574786ed8c01901d

commit 5407ae12413f9dd3edc4b4a4574786ed8c01901d
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu Sep 08 19:53:19 2016

Get rid of "Open in Chrome" from EmbedContentViewActivity

Discussion resulted in zero-ish cases where this would be useful.

BUG= 644848 

Review-Url: https://codereview.chromium.org/2328703002
Cr-Commit-Position: refs/heads/master@{#417370}

[modify] https://crrev.com/5407ae12413f9dd3edc4b4a4574786ed8c01901d/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java

Comment 4 by dfalcant...@chromium.org, Sep 8 2016

Status: Fixed (was: Started)
►

Sign in to add a comment