User pod's submit button breaks the pod on chrome desktop |
||||||||
Issue descriptionHi Sammie, looks like your CL to add a submit button to the user pod breaks the pod on desktop: https://codereview.chromium.org/2254623003 the width of the .auth-container and the height of the submit button seem to be causes. I personally don't think desktop needs to inherit this feature. but if you decide not to make cros specific, I think either there should be more resilient css in user_pod_row.css or it should be overridden in c/b/r/md_user_manager/user_manager.html (as a last resort). on a related note, chrome://theme/IDR_LOGIN_PASSWORD_CAPS_LOCK is not a valid resource on desktop. and i believe password fields get native OS notification for capslock. I think that feature should be cros specific.
,
Sep 7 2016
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4 commit 8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4 Author: sammiequon <sammiequon@chromium.org> Date: Tue Sep 13 21:55:19 2016 Submit button incompatiable with desktop chrome. Due to some complications I was not actually reproduce these bugs on desktop chrome. They should at the very least fix the bugs where the submit button shows up. I have confirmed they work as before on the chromeos side. BUG= 643066 , 643069 ,644325, 644843 Review-Url: https://codereview.chromium.org/2326833002 Cr-Commit-Position: refs/heads/master@{#418384} [modify] https://crrev.com/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4/ui/login/account_picker/user_pod_row.css [modify] https://crrev.com/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4/ui/login/account_picker/user_pod_row.js [modify] https://crrev.com/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4/ui/login/account_picker/user_pod_template.html
,
Sep 14 2016
,
Sep 14 2016
Thank you sammie, it seems to be fixed on desktop. just out of curiosity, why is the merge necessary? the initial changes landed on Aug 31st after M54 branch point https://chromium.googlesource.com/chromium/src/+/29276a7a0b4a0d59fa0a420cf9e7885286020bc4
,
Sep 14 2016
Hi Moe, the change that broke this (https://bugs.chromium.org/p/chromium/issues/detail?id=638643) has been merged.
,
Sep 14 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 15 2016
Could you please confirm whether this change is baked/verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) so that we could take this for next Beta Release.
,
Sep 15 2016
Would like to take the merge after verifying the fix in #3. It would be great to have the manual steps to proceed further.
,
Sep 15 2016
Had an offline conversation with Sami,please follow the steps mentioned in below issues for verification. https://bugs.chromium.org/p/chromium/issues/detail?id=644624 https://bugs.chromium.org/p/chromium/issues/detail?id=644235 https://bugs.chromium.org/p/chromium/issues/detail?id=643069 https://bugs.chromium.org/p/chromium/issues/detail?id=643066
,
Sep 16 2016
Verified the Fix of the issues listed above on Windows 10, Mac OS 10.11.6 and Linux Ubuntu 14.04 on chrome version: 55.0.2862.0. Issue 644624 (Merged into Issue 643066 ): There is no 'Submit' button seen hence the scenario doesn't hold. [Screenshot: 643066.png] Issue 644235 : Fix is working as intended and the user-name field layout is proper. [Screenshot: 644235.png] Issue 643069 : There is no 'Submit' button seen hence the scenario doesn't hold. So as per the above test, C#3 CL looks to be working as intended. Hence adding the verified label.
,
Sep 18 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19 2016
Please merge your change to M54 (branch: 2840) before 4.00 PM PST by Tuesday ( 09/20) if you like to make this fix for next Beta Release.
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80dd269ca1f309fc184c94e6e4f642b43cd563c5 commit 80dd269ca1f309fc184c94e6e4f642b43cd563c5 Author: Jacob Dufault <jdufault@google.com> Date: Tue Sep 20 23:28:03 2016 Submit button incompatiable with desktop chrome. Due to some complications I was not actually reproduce these bugs on desktop chrome. They should at the very least fix the bugs where the submit button shows up. I have confirmed they work as before on the chromeos side. BUG= 643066 , 643069 ,644325, 644843 Review-Url: https://codereview.chromium.org/2326833002 Cr-Commit-Position: refs/heads/master@{#418384} (cherry picked from commit 8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4) Review URL: https://codereview.chromium.org/2357623003 . Cr-Commit-Position: refs/branch-heads/2840@{#450} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.css [modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.js [modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_template.html
,
Sep 21 2016
Issue 643066 , Issue 643069 has been verified on the latest M-54(54.0.2840.34) and updated respectively. Adding the verified label for this one as well.
,
Sep 21 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80dd269ca1f309fc184c94e6e4f642b43cd563c5 commit 80dd269ca1f309fc184c94e6e4f642b43cd563c5 Author: Jacob Dufault <jdufault@google.com> Date: Tue Sep 20 23:28:03 2016 Submit button incompatiable with desktop chrome. Due to some complications I was not actually reproduce these bugs on desktop chrome. They should at the very least fix the bugs where the submit button shows up. I have confirmed they work as before on the chromeos side. BUG= 643066 , 643069 ,644325, 644843 Review-Url: https://codereview.chromium.org/2326833002 Cr-Commit-Position: refs/heads/master@{#418384} (cherry picked from commit 8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4) Review URL: https://codereview.chromium.org/2357623003 . Cr-Commit-Position: refs/branch-heads/2840@{#450} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.css [modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.js [modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_template.html |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mahmadi@chromium.org
, Sep 7 2016