Issue 644834 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	xixuan@chromium.org
Closed:	Oct 2016
Cc:	█ dshi@chromium.org █ pho...@chromium.org █ shuqianz@chromium.org
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	----
VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

build_externals won't update any package versions

Project Member Reported by xixuan@chromium.org, Sep 7 2016

Issue description

There exist a bug in def is_needed() of external_packages.py, to compare two version strings to detect whether the packages are needed to update, but the comparison always return False. 

This causes most of the packages are not updated and far away from the required version.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ebe4631ff1ea61a6846d2424c37e9718a1726ddd

commit ebe4631ff1ea61a6846d2424c37e9718a1726ddd
Author: xixuan <xixuan@chromium.org>
Date: Wed Sep 07 21:45:49 2016

Autotest: Let build_externals update the newest packages.

Previously, when build_externals checks whether there's a need to update a
package, it always return False. This causes some out-of-dated packages.

This CL updates to check the version of packages correctly.

BUG= chromium:644834 
TEST=Run build_externals.py in local workstation.

Change-Id: I09edbb19ba70f31299f0177d87f33a6cce4ed58e
Reviewed-on: https://chromium-review.googlesource.com/382592
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/ebe4631ff1ea61a6846d2424c37e9718a1726ddd/utils/external_packages.py