New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644811 link

Starred by 3 users
Status: Fixed
Owner:
qiangchen@chromium.org
Closed: Dec 2016
Cc:
qiangchen@chromium.org
m...@chromium.org
█ x...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove deprecated DesktopMedia* code.

Project Member Reported by msw@chromium.org, Sep 7 2016 
Remove deprecated DesktopMedia* code.

See chrome/browser/ui/views/desktop_media_picker_views_deprecated*
// TODO(qiangchen): Remove this file after new UI is done, and remove related
// resource strings, such as IDS_DESKTOP_MEDIA_PICKER_AUDIO_SHARE_TOOLTIP_NONE.

Came up in codesearch and I couldn't find a bug filed for this code health task.

Comment 1 by qiangchen@chromium.org, Sep 22 2016

Cc: x...@chromium.org qiangchen@chromium.org m...@chromium.org
 Issue 648673  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752

commit 41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752
Author: qiangchen <qiangchen@chromium.org>
Date: Wed Dec 14 21:24:00 2016

Remove Deprecate Code For Desktop Capture Picker Old UI

This is a code clean up CL, in which we remove the code for old UI of
desktop capture picker. As we found the new UI works well.

BUG= 644811 

Review-Url: https://codereview.chromium.org/2560333002
Cr-Commit-Position: refs/heads/master@{#438629}

[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/app/generated_resources.grd
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/browser/BUILD.gn
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/browser/about_flags.cc
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/media/combined_desktop_media_list.cc
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/media/combined_desktop_media_list.h
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/media/combined_desktop_media_list_unittest.cc
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated.h
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated.mm
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_deprecated_unittest.mm
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/ui/views/desktop_media_picker_views_deprecated.cc
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/ui/views/desktop_media_picker_views_deprecated.h
[delete] https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8/chrome/browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/chrome/test/BUILD.gn
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/extensions/common/switches.cc
[modify] https://crrev.com/41e08a84665f6d5deeaf5c2ddabb7cbcdf7f8752/extensions/common/switches.h

Comment 3 by qiangchen@chromium.org, Dec 14 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment