The laser pointer should consume events like the partial magnifier. Users should not be able to click the screen when the laser pointer is active.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/203ae0296e08db2452a4558d3e84dcf713f6badf commit 203ae0296e08db2452a4558d3e84dcf713f6badf Author: sammiequon <sammiequon@chromium.org> Date: Sun Sep 18 17:23:42 2016 chromeos: Laser tool blocks events from propagating. After discussion concluded the best way was to delegate the laser pointer out of ash/common. Moved all the laser related files into ash/laser. LaserPointerController.* replaces LaserPointerMode.* and it inherits from EventHandler to grab the events and propagate them to LaserPointerView/LaserPointerPoints, which remain the same. LaserPointerMode just inherits common palette tool and calls the delegate. BUG= 644804 TEST=ash_unittests --gtest_filter="LaserPointer*" https://screenshot.googleplex.com/BtwX1GTCpcW Review-Url: https://codereview.chromium.org/2311393004 Cr-Commit-Position: refs/heads/master@{#419400} [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/BUILD.gn [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/aura/wm_shell_aura.h [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/common/palette_delegate.h [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/common/system/chromeos/palette/palette_tool.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/common/system/chromeos/palette/tools/laser_pointer_mode.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/common/system/chromeos/palette/tools/laser_pointer_mode.h [delete] https://crrev.com/9ea2a739531edffad0859fdfd0a53f1f039026e4/ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.cc [delete] https://crrev.com/9ea2a739531edffad0859fdfd0a53f1f039026e4/ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.h [delete] https://crrev.com/9ea2a739531edffad0859fdfd0a53f1f039026e4/ash/common/system/chromeos/palette/tools/laser_pointer_unittest.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/common/test/test_palette_delegate.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/common/test/test_palette_delegate.h [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/common/wm_shell.h [add] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_controller.cc [add] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_controller.h [add] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_controller_test_api.cc [add] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_controller_test_api.h [add] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_controller_unittest.cc [rename] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_points.cc [rename] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_points.h [rename] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_points_test_api.cc [rename] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_points_test_api.h [rename] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_view.cc [rename] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/laser/laser_pointer_view.h [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/magnifier/partial_magnification_controller.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/shell.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/shell.h [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/chrome/browser/ui/ash/palette_delegate_chromeos.cc [modify] https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf/chrome/browser/ui/ash/palette_delegate_chromeos.h
Your change meets the bar and is auto-approved for M54 (branch: 2840)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7c7f28d53e55047046c1f985885433486150abc commit a7c7f28d53e55047046c1f985885433486150abc Author: Jacob Dufault <jdufault@google.com> Date: Wed Sep 21 19:58:04 2016 chromeos: Laser tool blocks events from propagating. After discussion concluded the best way was to delegate the laser pointer out of ash/common. Moved all the laser related files into ash/laser. LaserPointerController.* replaces LaserPointerMode.* and it inherits from EventHandler to grab the events and propagate them to LaserPointerView/LaserPointerPoints, which remain the same. LaserPointerMode just inherits common palette tool and calls the delegate. BUG= 644804 TEST=ash_unittests --gtest_filter="LaserPointer*" https://screenshot.googleplex.com/BtwX1GTCpcW Review-Url: https://codereview.chromium.org/2311393004 Cr-Commit-Position: refs/heads/master@{#419400} (cherry picked from commit 203ae0296e08db2452a4558d3e84dcf713f6badf) Review URL: https://codereview.chromium.org/2361563002 . Cr-Commit-Position: refs/branch-heads/2840@{#472} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/BUILD.gn [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/ash.gyp [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/aura/wm_shell_aura.h [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/common/palette_delegate.h [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/common/system/chromeos/palette/tools/laser_pointer_mode.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/common/system/chromeos/palette/tools/laser_pointer_mode.h [delete] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.cc [delete] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.h [delete] https://crrev.com/910386ff9b57445af8966322a34fe578dbba6681/ash/common/system/chromeos/palette/tools/laser_pointer_unittest.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/common/test/test_palette_delegate.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/common/test/test_palette_delegate.h [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/common/wm_shell.h [add] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_controller.cc [add] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_controller.h [add] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_controller_test_api.cc [add] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_controller_test_api.h [add] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_controller_unittest.cc [rename] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_points.cc [rename] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_points.h [rename] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_points_test_api.cc [rename] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_points_test_api.h [rename] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_view.cc [rename] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/laser/laser_pointer_view.h [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/magnifier/partial_magnification_controller.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/shell.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/shell.h [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/chrome/browser/ui/ash/palette_delegate_chromeos.cc [modify] https://crrev.com/a7c7f28d53e55047046c1f985885433486150abc/chrome/browser/ui/ash/palette_delegate_chromeos.h
Comment 1 by bugdroid1@chromium.org
, Sep 18 2016