GATT connections drop immediately |
|||||||||
Issue descriptionWhen we try to initiate a GATT connection from inside the container, the connection will drop immediately because we don't keep the device::BluetoothGattConnection object that we are given ownership of around. This results in the object being quickly destroyed and disconnecting the remote device.
,
Sep 8 2016
Without this no GATT devce will function with ARC++ correct? That seems reasonable to merge if the change is ARC specific, but before performing the merge please verify this functions properly on canary, unless you are super duper confident in the patch.
,
Sep 8 2016
I verified on M55 and M53.
,
Sep 8 2016
Assigning to steel@ for drover.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/603a31f74609f94f2a70377193c6094ea74e5d83 commit 603a31f74609f94f2a70377193c6094ea74e5d83 Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 21:16:14 2016 arc/bluetooth: Save BluetoothGattConnection objects When we make outbound GATT connections, we were immediately letting them expire in OnGattConnected, which meant we would disconnect remote devices as soon as they were connected to us. BUG= 644792 TEST=make GATT connections from inside the container and verify that they stay connected, disconnect and verify that the device is disconnected Review-Url: https://codereview.chromium.org/2321693002 Cr-Commit-Position: refs/heads/master@{#417097} (cherry picked from commit fcca36a57736c9f17c30607904a4e73b95461744) Review URL: https://codereview.chromium.org/2320293002 . Cr-Commit-Position: refs/branch-heads/2785@{#857} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/603a31f74609f94f2a70377193c6094ea74e5d83/components/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/603a31f74609f94f2a70377193c6094ea74e5d83/components/arc/bluetooth/arc_bluetooth_bridge.h
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f11bdf8310561eb3fa7354dff30c28274efc263f commit f11bdf8310561eb3fa7354dff30c28274efc263f Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 21:53:16 2016 arc/bluetooth: Save BluetoothGattConnection objects When we make outbound GATT connections, we were immediately letting them expire in OnGattConnected, which meant we would disconnect remote devices as soon as they were connected to us. BUG= 644792 TEST=make GATT connections from inside the container and verify that they stay connected, disconnect and verify that the device is disconnected Review-Url: https://codereview.chromium.org/2321693002 Cr-Commit-Position: refs/heads/master@{#417097} (cherry picked from commit fcca36a57736c9f17c30607904a4e73b95461744) Review URL: https://codereview.chromium.org/2319213005 . Cr-Commit-Position: refs/branch-heads/2840@{#252} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f11bdf8310561eb3fa7354dff30c28274efc263f/components/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/f11bdf8310561eb3fa7354dff30c28274efc263f/components/arc/bluetooth/arc_bluetooth_bridge.h
,
Sep 9 2016
Thanks Miao!
,
Sep 28 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f11bdf8310561eb3fa7354dff30c28274efc263f commit f11bdf8310561eb3fa7354dff30c28274efc263f Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 21:53:16 2016 arc/bluetooth: Save BluetoothGattConnection objects When we make outbound GATT connections, we were immediately letting them expire in OnGattConnected, which meant we would disconnect remote devices as soon as they were connected to us. BUG= 644792 TEST=make GATT connections from inside the container and verify that they stay connected, disconnect and verify that the device is disconnected Review-Url: https://codereview.chromium.org/2321693002 Cr-Commit-Position: refs/heads/master@{#417097} (cherry picked from commit fcca36a57736c9f17c30607904a4e73b95461744) Review URL: https://codereview.chromium.org/2319213005 . Cr-Commit-Position: refs/branch-heads/2840@{#252} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f11bdf8310561eb3fa7354dff30c28274efc263f/components/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/f11bdf8310561eb3fa7354dff30c28274efc263f/components/arc/bluetooth/arc_bluetooth_bridge.h
,
Mar 3 2017
,
Mar 3 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ejcaruso@chromium.org
, Sep 8 2016Labels: Merge-Request-53 Merge-Request-54