New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644788 link

Starred by 1 user
Status: Assigned
Owner:
█ satay...@samsung.com
Last visit > 30 days ago
Cc:
█ billy.ja...@samsung.com
munukutla.praveen@chromium.org
skobes@chromium.org
bokan@chromium.org
█ satay...@samsung.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Main frame doesn't create RootFrameViewport in some webkit_unit_tests.

Project Member Reported by satay...@samsung.com, Sep 7 2016 
Version: TOT
OS: ALL

Main frame doesn't create RootFrameViewport in some webkit_unit_tests.

more info @ https://codereview.chromium.org/2198853002/diff/140001/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode2682

please check the test case failures @
https://codereview.chromium.org/2198853002/#ps180001

Comment 1 by dtapu...@chromium.org, Sep 7 2016

Components: -Blink Blink>Scroll

Comment 2 by skobes@chromium.org, Sep 7 2016

Cc: satay...@samsung.com
 Issue 644787  has been merged into this issue.

Comment 3 by satay...@samsung.com, Sep 17 2016 

content_browsertests (with patch) content_browsertests (with patch)

failures:
FindRequestManagerTests/FindRequestManagerTest.RemoveFrame/1
SitePerProcessBrowserTest.WindowNameReplication
SitePerProcessIgnoreCertErrorsBrowserTest.PassiveMixedContentInIframe
SitePerProcessBrowserTest.InputEventRouterTouchpadGestureTargetTest
SitePerProcessBrowserTest.NestedSurfaceHitTestTest
SitePerProcessBrowserTest.InputEventRouterGestureTargetQueueTest
SitePerProcessHighDPIBrowserTest.SubframeLoadsWithCorrectDeviceScaleFactor
SitePerProcessBrowserTest.DynamicSandboxFlagsRendererInitiatedNavigation
SitePerProcessBrowserTest.IndexedFrameAccess
SitePerProcessBrowserTest.SandboxFlagsReplication
TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup
TopDocumentIsolationTest.PopupAndRedirection
SitePerProcessBrowserTest.CreateChildFrameAfterKillingProcess
SitePerProcessAccessibilityBrowserTest.CrossSiteIframeAccessibility
SitePerProcessBrowserTest.OriginReplication
SitePerProcessBrowserTest.LoadEventForwarding
SitePerProcessBrowserTest.ScreenCoordinates
WakeLockTest.UnlockAfterCrashOutOfProcessFrame
SitePerProcessBrowserTest.NavigatingSubframePreservesOpenerInParent
TopDocumentIsolationTest.CrossSiteDeeplyNested
TopDocumentIsolationTest.CrossSiteAtLevelTwo
SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
SitePerProcessHighDPIBrowserTest.HighDPICreateContextMenuTest
SitePerProcessGestureBrowserTest.SubframeGesturePinchGoesToMainFrame
SitePerProcessBrowserTest.CrossSiteIframeBlockedByParentCSPFromHeaders
SitePerProcessBrowserTest.DocumentActiveElement
SitePerProcessHighDPIBrowserTest.SurfaceHitTestTest
SitePerProcessBrowserTest.NavigateMainFrameToChildSite
SitePerProcessBrowserTest.CrossSiteIframeBlockedByXFrameOptionsOrCSP
SitePerProcessBrowserTest.SandboxFlagsNotInheritedBeforeNavigation
DumpAccessibilityTreeTest.AccessibilityIframeCrossProcess
SitePerProcessBrowserTest.ParentDetachRemoteChild
SitePerProcessBrowserTest.SubframeGestureEventRouting
FindRequestManagerTests/FindRequestManagerTest.RapidFire/1
SitePerProcessBrowserTest.CrossProcessFocusChangeFiresBlurEvents
SitePerProcessBrowserTest.SurfaceHitTestTest
SitePerProcessGestureBrowserTest.MainframeGesturePinchGoesToMainFrame
SitePerProcessBrowserTest.KillingRendererClearsDescendantProxies
SitePerProcessBrowserTest.NavigateSubframeToAboutBlankInSessionHistory
SitePerProcessBrowserTest.TwoSubframesCreatePopupMenuWidgetsSimultaneously
SitePerProcessBrowserTest.OriginUpdatesReachProxies
SitePerProcessBrowserTest.NavigateCrashedSubframeToSameSite
TopDocumentIsolationTest.NavigateToSubframeSite
SitePerProcessBrowserTest.PopupMenuTest
DumpAccessibilityTreeTest.AccessibilityIframeTransformNested
SitePerProcessBrowserTest.FileChooserInSubframe
SitePerProcessBrowserTest.ProcessTransferAfterError
SitePerProcessBrowserTest.FrameOwnerPropertiesPropagationScrolling
SitePerProcessBrowserTest.CreateProxiesForNewFrames
SitePerProcessBrowserTest.CrossSiteIframeBlockedByParentCSPFromMeta
SitePerProcessBrowserTest.SubframePostMessage
SitePerProcessBrowserTest.FrameOwnerPropertiesPropagationMargin
MHTMLGenerationSitePerProcessTest.GenerateMHTML
SitePerProcessBrowserTest.UpdateSubframeOpener
IsolatedDevToolsProtocolTest.ControlNavigationsChildFrames
SitePerProcessBrowserTest.NewRenderFrameProxyPreservesOpener
SitePerProcessBrowserTest.LoadEventForwardingWhilePendingDeletion
SitePerProcessBrowserTest.RFPHDestruction
SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations
SitePerProcessBrowserTest.OpenPopupWithRemoteParent
TopDocumentIsolationTest.ReturnToTopSite
SitePerProcessBrowserTest.CrossProcessMouseEnterAndLeaveTest
SitePerProcessBrowserTest.CrossSiteIframeBlockedByCSPInheritedBySrcDocParent
SitePerProcessBrowserTest.NavigateInUnloadHandler
SitePerProcessBrowserTest.ProxyCreationSkipsSubtree
SitePerProcessBrowserTest.NavigateSubframeToDataUrlInSessionHistory
SitePerProcessBrowserTest.ScrollEventToOOPIF
SitePerProcessBrowserTest.SessionHistoryReplication
SitePerProcessBrowserTest.DynamicSandboxFlags
SitePerProcessBrowserTest.RestrictFrameDetach
SitePerProcessBrowserTest.OpenUnsandboxedPopupFromSandboxedFrame
WakeLockTest.OutOfProcessFrame
SitePerProcessBrowserTest.NavigateRemoteFrame
FindRequestManagerTests/FindRequestManagerTest.CharacterByCharacter/1
SitePerProcessIgnoreCertErrorsBrowserTest.PassiveMixedContentInIframeWithUpgrade
SitePerProcessBrowserTest.DiscoverNamedFrameFromAncestorOfOpener
SitePerProcessBrowserTest.DetachInUnloadHandler
SitePerProcessBrowserTest.SubframeTouchEventRouting
SitePerProcessBrowserTest.VisibilityChange
SitePerProcessBrowserTest.TwoSubframesCreatePopupsSimultaneously
SitePerProcessBrowserTest.AllowFullscreen
SitePerProcessBrowserTest.DynamicWindowName
SitePerProcessBrowserTest.DynamicSandboxFlagsRemoteToLocal
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs
DumpAccessibilityTreeTest.AccessibilityIframeTransformNestedCrossProcess
SitePerProcessBrowserTest.SubframeWindowFocus
SitePerProcessBrowserTest.PostMessageWithSubframeOnOpenerChain
SitePerProcessBrowserTest.NavigateProxyAndDetachBeforeProvisionalFrameCreation
SitePerProcessBrowserTest.NavigateProxyAndDetachBeforeCommit
SitePerProcessBrowserTest.CreateContextMenuTest
SitePerProcessBrowserTest.DiscoverFrameAfterSettingWindowName
TopDocumentIsolationTest.FramesForSitesInHistory
SitePerProcessBrowserTest.CloseSubframeWidgetAndViewOnProcessExit
SitePerProcessIgnoreCertErrorsBrowserTest.SubresourceWithCertificateErrors
RenderWidgetHostViewChildFrameTest.Screen
SitePerProcessBrowserTest.NavigateSubframeWithOpener
FindRequestManagerTests/FindRequestManagerTest.Basic/1
SitePerProcessBrowserTest.SurfaceHitTestPointerEventsNone
SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcessWithSubtree
SitePerProcessBrowserTest.NavigateSiblingsToSameProcess
SitePerProcessBrowserTest.NewPopupInheritsSandboxFlagsFromOpener
SitePerProcessBrowserTest.UserInteractionForChildFrameTest
SitePerProcessBrowserTest.CrossSiteIframe
SitePerProcessBrowserTest.SandboxFlagsInheritance
SitePerProcessBrowserTest.SubframePendingAndBackToSameSiteInstance
SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcess
TopDocumentIsolationTest.NavigateSubframeToTopSite
SitePerProcessBrowserTest.CrossProcessMouseCapture
DumpAccessibilityTreeTest.AccessibilityIframeTransformCrossProcess

Comment 4 by satay...@samsung.com, Sep 19 2016 

interactive_ui_tests (with patch) on Windows-7-SP1 interactive_ui_tests (with patch) on Windows-7-SP1

209 disabled
4 flaky
failed 14

failures:
SitePerProcessInteractiveBrowserTest.FullscreenElementInABAAndExitViaJS
SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame
SitePerProcessTextInputManagerTest.TrackSelectionBoundsForAllFrames
SitePerProcessTextInputManagerTest.ResetStateAfterFrameDetached
SitePerProcessTextInputManagerTest.ResetStateAfterChildNavigation
SitePerProcessInteractiveBrowserTest.DocumentHasFocus
SitePerProcessTextInputManagerTest.ResetTextInputStateOnActiveWidgetChange
SitePerProcessInteractiveBrowserTest.SubframeKeyboardEventRouting
SitePerProcessInteractiveBrowserTest.SequentialFocusNavigation
SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames
SitePerProcessTextInputManagerTest.TrackCompositionRangeForAllFrames
SitePerProcessInteractiveBrowserTest.FullscreenElementInMultipleSubframes
SitePerProcessInteractiveBrowserTest.RenderWidgetHostDeletedWhileMouseLocked
SitePerProcessTextInputManagerTest.TrackStateWhenSwitchingFocusedFrames

Comment 5 by satay...@samsung.com, Sep 19 2016 

content_browsertests (with patch) on Windows-7-SP1 content_browsertests (with patch) on Windows-7-SP1

118 disabled
16 flaky
failed 91

failures:
FindRequestManagerTests/FindRequestManagerTest.RemoveFrame/1
SitePerProcessBrowserTest.WindowNameReplication
SitePerProcessBrowserTest.InputEventRouterTouchpadGestureTargetTest
SitePerProcessBrowserTest.NestedSurfaceHitTestTest
SitePerProcessBrowserTest.InputEventRouterGestureTargetQueueTest
SitePerProcessHighDPIBrowserTest.SubframeLoadsWithCorrectDeviceScaleFactor
SitePerProcessBrowserTest.DynamicSandboxFlagsRendererInitiatedNavigation
SitePerProcessBrowserTest.IndexedFrameAccess
SitePerProcessBrowserTest.SandboxFlagsReplication
TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup
TopDocumentIsolationTest.PopupAndRedirection
SitePerProcessAccessibilityBrowserTest.CrossSiteIframeAccessibility
SitePerProcessBrowserTest.OriginReplication
SitePerProcessBrowserTest.ScreenCoordinates
WakeLockTest.UnlockAfterCrashOutOfProcessFrame
SitePerProcessBrowserTest.NavigatingSubframePreservesOpenerInParent
TopDocumentIsolationTest.CrossSiteDeeplyNested
TopDocumentIsolationTest.CrossSiteAtLevelTwo
SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
SitePerProcessGestureBrowserTest.SubframeGesturePinchGoesToMainFrame
SitePerProcessBrowserTest.CrossSiteIframeBlockedByParentCSPFromHeaders
SitePerProcessBrowserTest.DocumentActiveElement
SitePerProcessBrowserTest.NavigateMainFrameToChildSite
SitePerProcessBrowserTest.CrossSiteIframeBlockedByXFrameOptionsOrCSP
SitePerProcessBrowserTest.SandboxFlagsNotInheritedBeforeNavigation
DumpAccessibilityTreeTest.AccessibilityIframeCrossProcess
SitePerProcessBrowserTest.ParentDetachRemoteChild
SitePerProcessBrowserTest.SubframeGestureEventRouting
FindRequestManagerTests/FindRequestManagerTest.RapidFire/1
SitePerProcessBrowserTest.CrossProcessFocusChangeFiresBlurEvents
SitePerProcessBrowserTest.SurfaceHitTestTest
SitePerProcessGestureBrowserTest.MainframeGesturePinchGoesToMainFrame
SitePerProcessBrowserTest.KillingRendererClearsDescendantProxies
DumpAccessibilityTreeTest.AccessibilityIframeCoordinatesCrossProcess
SitePerProcessBrowserTest.NavigateSubframeToAboutBlankInSessionHistory
SitePerProcessBrowserTest.TwoSubframesCreatePopupMenuWidgetsSimultaneously
SitePerProcessBrowserTest.OriginUpdatesReachProxies
SitePerProcessBrowserTest.NavigateCrashedSubframeToSameSite
SitePerProcessBrowserTest.PopupMenuTest
DumpAccessibilityTreeTest.AccessibilityIframeTransformNested
SitePerProcessBrowserTest.FileChooserInSubframe
SitePerProcessBrowserTest.ProcessTransferAfterError
SitePerProcessBrowserTest.FrameOwnerPropertiesPropagationScrolling
SitePerProcessBrowserTest.CrossSiteIframeBlockedByParentCSPFromMeta
SitePerProcessBrowserTest.SubframePostMessage
SitePerProcessBrowserTest.FrameOwnerPropertiesPropagationMargin
SitePerProcessBrowserTest.UpdateSubframeOpener
IsolatedDevToolsProtocolTest.ControlNavigationsChildFrames
SitePerProcessBrowserTest.LoadEventForwardingWhilePendingDeletion
SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations
SitePerProcessBrowserTest.OpenPopupWithRemoteParent
TopDocumentIsolationTest.ReturnToTopSite
SitePerProcessBrowserTest.CrossProcessMouseEnterAndLeaveTest
SitePerProcessBrowserTest.CrossSiteIframeBlockedByCSPInheritedBySrcDocParent
SitePerProcessBrowserTest.NavigateInUnloadHandler
SitePerProcessBrowserTest.NavigateSubframeToDataUrlInSessionHistory
SitePerProcessBrowserTest.ScrollEventToOOPIF
SitePerProcessBrowserTest.SessionHistoryReplication
SitePerProcessBrowserTest.DynamicSandboxFlags
SitePerProcessBrowserTest.OpenUnsandboxedPopupFromSandboxedFrame
WakeLockTest.OutOfProcessFrame
FindRequestManagerTests/FindRequestManagerTest.CharacterByCharacter/1
SitePerProcessIgnoreCertErrorsBrowserTest.PassiveMixedContentInIframeWithUpgrade
SitePerProcessBrowserTest.DiscoverNamedFrameFromAncestorOfOpener
SitePerProcessBrowserTest.DetachInUnloadHandler
SitePerProcessBrowserTest.SubframeTouchEventRouting
SitePerProcessBrowserTest.VisibilityChange
SitePerProcessBrowserTest.TwoSubframesCreatePopupsSimultaneously
SitePerProcessBrowserTest.AllowFullscreen
SitePerProcessBrowserTest.DynamicWindowName
SitePerProcessBrowserTest.DynamicSandboxFlagsRemoteToLocal
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs
DumpAccessibilityTreeTest.AccessibilityIframeTransformNestedCrossProcess
SitePerProcessBrowserTest.SubframeWindowFocus
SitePerProcessBrowserTest.PostMessageWithSubframeOnOpenerChain
SitePerProcessBrowserTest.NavigateProxyAndDetachBeforeProvisionalFrameCreation
SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcess
SitePerProcessBrowserTest.CreateContextMenuTest
SitePerProcessBrowserTest.DiscoverFrameAfterSettingWindowName
SitePerProcessBrowserTest.CloseSubframeWidgetAndViewOnProcessExit
SitePerProcessBrowserTest.NavigateSubframeWithOpener
FindRequestManagerTests/FindRequestManagerTest.Basic/1
SitePerProcessBrowserTest.SurfaceHitTestPointerEventsNone
SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcessWithSubtree
SitePerProcessBrowserTest.NavigateSiblingsToSameProcess
SitePerProcessBrowserTest.NewPopupInheritsSandboxFlagsFromOpener
SitePerProcessBrowserTest.SandboxFlagsInheritance
SitePerProcessBrowserTest.NavigateProxyAndDetachBeforeCommit
TopDocumentIsolationTest.NavigateSubframeToTopSite
SitePerProcessBrowserTest.CrossProcessMouseCapture
DumpAccessibilityTreeTest.AccessibilityIframeTransformCrossProcess

Comment 6 by satay...@samsung.com, Sep 19 2016

Cc: billy.ja...@samsung.com
+biljith , PTAL at this issue.

Comment 7 by bokan@chromium.org, Oct 5 2016 

We can't create a RootFrameView until we have a layout viewport. When root-layer-scrolls is on, this means we have to wait until a LayoutView is created which happens only when we attach/install a document to the main frame. This should happen in this call-chain:

DocumentLoader::createWriterFor -> LocalDOMWindow::installNewDocument -> Document::initialize

How does this bug manifest itself in a problem? I see most of the failures are in SitePerProcess. We only need a RootFrameView on the main frame on a page. In OOPIF, a remote frame will have a separate renderer but that renderer shouldn't create an RFV since the main frame is remote to that process.
►

Sign in to add a comment