Clicks do not always register in SSP section when swatch popover is open |
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.89 Safari/537.36 Steps to reproduce the problem: 1. Open DevTools on any web page. 2. Add a new style rule in Styles Sidebar Pane. 3. Add "background-color: red;" and "color: blue;" to the style rule. 4. Click on one of the new color swatches to open the color picker popover. 5. With that popover open, click on the other color swatch in the same style section. What is the expected behavior? The click should be registered, and the other swatch popover should open, revealing the color picker for that swatch. Similarly, when clicking on the property text in the same property section, the text editor should open to allow you to change the property text. Note that if you click a color swatch in another separate style rule/section, the click will go through and the second popover will open. This is the expected behavior. What went wrong? The properties in the edited section are replaced and re-rendered when the popover is hidden. As a result, the swatch being clicked is being replaced, and the click does not always go through. Did this work before? No Chrome version: 53.0.2785.89 Channel: stable OS Version: 14.04.5 Flash Version: Shockwave Flash 22.0 r0 Here is the initial fix: https://codereview.chromium.org/2307463004/
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d92a75f417b99a2abebb33234695eb60b96d04f1 commit d92a75f417b99a2abebb33234695eb60b96d04f1 Author: flandy <flandy@google.com> Date: Thu Sep 08 01:10:37 2016 Revert of DevTools: Allow clicks to register in SSP when swatch popover is open (patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ ) Reason for revert: This breaks editing color swatches within shadow swatches. If you edit the color, and then edit the shadow, it reverts to the original color. We should further examine the effects of majorChange=true in applyStyleText. Original issue's description: > DevTools: Allow clicks to register in SSP when swatch popover is open > > Applying the style text to the tree element when the popover is hidden > causes the section to update, not allowing clicks to register. > > It is unnecessary to apply the style text when the popover is hidden > (unless reverting back to original property text) because the change > has already been applied. > > BUG= 644779 > > Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb > Cr-Commit-Position: refs/heads/master@{#417109} TBR=lushnikov@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 644779 Review-Url: https://codereview.chromium.org/2320533005 Cr-Commit-Position: refs/heads/master@{#417140} [modify] https://crrev.com/d92a75f417b99a2abebb33234695eb60b96d04f1/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js [modify] https://crrev.com/d92a75f417b99a2abebb33234695eb60b96d04f1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js [modify] https://crrev.com/d92a75f417b99a2abebb33234695eb60b96d04f1/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js
,
Sep 8 2016
,
Sep 9 2016
,
Sep 12 2016
The fix didn't make it. Assigning to lushnikov since flandy is out of the building. Checked and flandy has no other open bugs assigned to him. phew.
,
Sep 12 2016
,
Sep 29 2016
,
Dec 5 2017
Doesn't seem to be a big deal. Closing this. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2016