Use correct theme color for Blimp |
||
Issue descriptionCurrently in BlimpContentsImpl, we use a hard coded theme color BLIMP_THEME_COLOR for Blimp 0.6. Use the correct color in the future.
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f96e9a9fd95d7a9928de17effb1788de5f66691 commit 5f96e9a9fd95d7a9928de17effb1788de5f66691 Author: nyquist <nyquist@chromium.org> Date: Mon Sep 12 22:26:12 2016 [blimp] Fix theme color in tab switcher Before the CL https://codereview.chromium.org/2325763003/ landed, it was possible to use a theme color without alpha for the tab switcher toolbar, because the code was using the alpha from the underlying resource instead. However after that CL this was no longer possible and a correct theme color is required. The CL that added theme colors to the tab switcher for the new tab page for blimp tabs ( https://codereview.chromium.org/2325893002/ ) landed around the same time, and there was no test, so this was not caught in that CL, and it continued to use a theme color without alpha. This CL just adds the alpha channel to the theme color from Blimp, which means that it now propagates correctly throughout the codebase. BUG= 644467 , 644774 Review-Url: https://codereview.chromium.org/2335863002 Cr-Commit-Position: refs/heads/master@{#418078} [modify] https://crrev.com/5f96e9a9fd95d7a9928de17effb1788de5f66691/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java
,
Dec 6 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 9 2016