New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644766 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Aggregates remaining ARIA 1.1 work

Project Member Reported by nek...@chromium.org, Sep 7 2016

Issue description

Finish implementation of ARIA 1.1 standard.

1. Should be easy to implement:
details
errormessage
keyshortcuts
modal
placeholder
roledescription

2. More complex:
haspopup (changed relative to 1.0)
cell
feed
figure
table
term

3. Verify / complete implementation of:
colcount
colindex
colspan
rowspan
rowcount
rowindex

 
Owner: ----
Status: Available (was: Assigned)
Cc: shreera...@samsung.com
 Issue 475786  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d4f1b146e762edcc6a86dd880c95da651d71d3

commit c5d4f1b146e762edcc6a86dd880c95da651d71d3
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Dec 28 16:42:18 2016

ARIA 1.1: implementation for aria-col-* and aria-row-*.

This patch adds implementation for aria-col-index, aria-col-count, aria-
col-span, aria-row-index, aria-row-count, aria-row-span from ARIA 1.1,
https://rawgit.com/w3c/aria/master/aria/aria.html.

For windows, aria-col-count, aria-col-index, aria-row-count, aria-row-
index, aria-col-span and aria-row-span are exposed as object attributes.

Based on http://codereview.chromium.org/1547643002 by je_julie,
which was in turn based on wkrev.com/190833 by n_wang.

BUG= 543050 , 644766 

Review-Url: https://codereview.chromium.org/2539503003
Cr-Commit-Position: refs/heads/master@{#440852}

[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/browser/accessibility/accessibility_tree_formatter_mac.mm
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/renderer/accessibility/blink_ax_tree_source.cc
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-col-attr-expected-android.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-col-attr-expected-blink.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-col-attr-expected-mac.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-col-attr-expected-win.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-col-attr.html
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-row-attr-expected-android.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-row-attr-expected-blink.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-row-attr-expected-mac.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-row-attr-expected-win.txt
[add] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/content/test/data/accessibility/aria/aria-row-attr.html
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/modules/accessibility/AXTable.h
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/modules/accessibility/AXTableCell.h
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/modules/accessibility/AXTableRow.h
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/third_party/WebKit/public/web/WebAXObject.h
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3/ui/accessibility/ax_tree_combiner.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df5ab817cb455c368ef3aeb147b2908d8247922b

commit df5ab817cb455c368ef3aeb147b2908d8247922b
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Jan 09 06:04:09 2017

Implement 5 ARIA 1.1 roles: cell, feed, figure, table, term

These 5 roles are all defined in the ARIA 1.1 editor's draft.
All 5 are quite trivial because we either already supported
them as a native HTML role, or we just pass them through
to assistive technology without affecting any semantics.

The spec is defined here:
https://rawgit.com/w3c/aria/master/aria/aria.html

The test expectations were checked against the latest
draft of the Core Accessibility API Mappings:
http://w3c.github.io/aria/core-aam/core-aam.html

BUG= 644766 

Review-Url: https://codereview.chromium.org/2607113003
Cr-Commit-Position: refs/heads/master@{#442199}

[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/renderer/accessibility/blink_ax_enum_conversion.cc
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-cell-expected-win.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-cell.html
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-feed-expected-mac.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-feed-expected-win.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-feed.html
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-figure-expected-mac.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-figure-expected-win.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-figure.html
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-table-expected-mac.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-table-expected-win.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-table.html
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-term-expected-mac.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-term-expected-win.txt
[add] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/content/test/data/accessibility/aria/aria-term.html
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-img-figure-expected.txt
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/df5ab817cb455c368ef3aeb147b2908d8247922b/ui/accessibility/platform/ax_platform_node_mac.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22632c56f2fe702261795bb3cd3f76a717addf4a

commit 22632c56f2fe702261795bb3cd3f76a717addf4a
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Jan 23 22:57:40 2017

Add sparse accessibility attribute interface to Blink

It's inefficient to have separate interfaces in blink::WebAXObject to
query for each possible attribute, especially when those attributes are
rare and obscure ARIA attributes. Calling getAttribute many times in a row
is wasteful since many Elements have a lot of attributes we don't care
about, and many ARIA attributes are quite rare.

This change introduces a new WebAXObject interface for returning sparse
attributes. Call it once and pass a callback function. The implementation
iterates over all of the attributes of the element and calls the callback
with each accessibility attribute found.

This change re-implements the following 3 ARIA attributes as sparse
attributes; they're covered by existing tests:
  aria-activedescendant
  aria-controls
  aria-flowto

BUG= 675994 , 644766 

Review-Url: https://codereview.chromium.org/2589273002
Cr-Commit-Position: refs/heads/master@{#445527}

[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/components/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/core/dom/QualifiedName.h
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/22632c56f2fe702261795bb3cd3f76a717addf4a/third_party/WebKit/public/web/WebAXObject.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ca955425af665573f7ad3210643bcb3486c69b5

commit 8ca955425af665573f7ad3210643bcb3486c69b5
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Jan 31 16:39:41 2017

Add 4 ARIA 1.1 attributes using new sparse attribute interface.

Adds support for 4 sparse ARIA 1.1 attributes:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-roledescription

Chrome support will be added in this follow-up change:
https://codereview.chromium.org/2587343004/

BUG= 675994 ,  644766 

Review-Url: https://codereview.chromium.org/2653063002
Cr-Commit-Position: refs/heads/master@{#447244}

[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/content/renderer/accessibility/blink_ax_tree_source.cc
[add] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1-expected.txt
[add] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-aria-1.1.html
[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/8ca955425af665573f7ad3210643bcb3486c69b5/third_party/WebKit/public/web/WebAXEnums.h

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e45f35b6aafa2a42782065192a37e778f0e6d24

commit 1e45f35b6aafa2a42782065192a37e778f0e6d24
Author: dmazzoni <dmazzoni@chromium.org>
Date: Thu Feb 02 06:41:15 2017

Implement aria-modal

This is the Blink part of the implementation, with tests.
It adds an isModal interface to accessible objects, and
implements it for both aria-modal, and for HTML dialogs.

The Chromium part of the implementation will follow.

BUG= 644766 

Review-Url: https://codereview.chromium.org/2666873005
Cr-Commit-Position: refs/heads/master@{#447712}

[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/components/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/components/test_runner/web_ax_object_proxy.h
[add] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/LayoutTests/accessibility/aria-modal.html
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal-expected.txt
[add] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal-expected.txt
[add] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal.html
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/1e45f35b6aafa2a42782065192a37e778f0e6d24/third_party/WebKit/public/web/WebAXObject.h

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca0b1e8456c010011b838b1f8d35027e45fc1c7d

commit ca0b1e8456c010011b838b1f8d35027e45fc1c7d
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri Feb 10 03:59:09 2017

Finish implementation and tests of 5 ARIA 1.1 attributes.

The changes that add support for these 5 new ARIA 1.1
attributes have landed:

  aria-details
  aria-errormessage
  aria-keyshortcuts
  aria-modal
  aria-roledescription

This change completes the implementation in Chrome, to the extent
that they are specified, and adds tests.

BUG= 675994 ,  644766 

Review-Url: https://codereview.chromium.org/2684543002
Cr-Commit-Position: refs/heads/master@{#449545}

[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/browser/accessibility/accessibility_tree_formatter_blink.cc
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/browser/accessibility/browser_accessibility_win.h
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/renderer/accessibility/blink_ax_tree_source.cc
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-activedescendant-expected-blink.txt
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-activedescendant.html
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-details-expected-blink.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-details-expected-win.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-details.html
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-errormessage-expected-blink.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-errormessage-expected-win.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-errormessage.html
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-keyshortcuts-expected-blink.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-keyshortcuts-expected-win.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-keyshortcuts.html
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-modal-expected-blink.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-modal-expected-win.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-modal.html
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-roledescription-expected-blink.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-roledescription-expected-mac.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-roledescription-expected-win.txt
[add] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/content/test/data/accessibility/aria/aria-roledescription.html
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/ui/accessibility/ax_node_data.h
[modify] https://crrev.com/ca0b1e8456c010011b838b1f8d35027e45fc1c7d/ui/accessibility/ax_tree_combiner.cc

Labels: NewComponent-Accessibility-Blink
Labels: NewComponent-Accessibility
Components: Blink>Accessibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-blink -newcomponent-accessibility
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55485479d83ebbdace3c7c60e463142931f4d6c5

commit 55485479d83ebbdace3c7c60e463142931f4d6c5
Author: nektar <nektar@chromium.org>
Date: Fri Apr 21 18:10:56 2017

Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox.

BUG= 644766 
R=dmazzoni@chromium.org, dtseng@chromium.org, michaelpg@chromium.org
TESTED=automation API test, manually with ChromeVox
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2799443002
Cr-Commit-Position: refs/heads/master@{#466392}

[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/chrome/test/data/extensions/api_test/automation/sites/attributes.html
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/content/test/data/accessibility/aria/aria-col-attr-expected-blink.txt
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/content/test/data/accessibility/aria/aria-col-attr.html
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/content/test/data/accessibility/aria/aria-row-attr-expected-blink.txt
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/content/test/data/accessibility/aria/aria-row-attr.html
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/55485479d83ebbdace3c7c60e463142931f4d6c5/ui/accessibility/ax_node_data.cc

Cc: igrigo...@chromium.org
Labels: triage-alice
Labels: -triage-alice

Comment 17 Deleted

nektar@/dmazzoni@ - any thoughts on what work remains here, other than fully implementing aria-modal on Mac?

Labels: triage-dtseng
Labels: -triage-dtseng
Project Member

Comment 21 by sheriffbot@chromium.org, Aug 13

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)

Sign in to add a comment