Update: this was approved by Chrome UI review

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6750eab17b2f45449fab74543ff2fdbcdc122a4e

commit 6750eab17b2f45449fab74543ff2fdbcdc122a4e
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Sep 20 23:01:37 2016

Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.

BUG= 644758 

Review-Url: https://codereview.chromium.org/2352213002
Cr-Commit-Position: refs/heads/master@{#419884}

[modify] https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e/ash/common/accelerators/accelerator_table.h
[modify] https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e/tools/metrics/actions/actions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23f688e8fe28d1b260cedba104bf0783331126d4

commit 23f688e8fe28d1b260cedba104bf0783331126d4
Author: afakhry <afakhry@chromium.org>
Date: Wed Sep 28 18:36:23 2016

Add the shortcut to toggle high contrast mode to the keyboard overlay

Screenshot https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LMUpQRG02OXRYU1k/view?usp=sharing

BUG= 644758 
TEST=open keyboard overlay, hit Ctrl+Alt, and look at the H key.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2379673002
Cr-Commit-Position: refs/heads/master@{#421587}

[modify] https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4/chrome/browser/resources/chromeos/keyboard_overlay_data.js
[modify] https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

This shortcut conflicts with page shortcuts that once worked like jump to next heading in Docs. We should probably revert as this is a regression.

As we discussed - the key combo needs to either be overrideable by the page or it needs to use the search key.

I filed 653330 to track the regression, I'll fix it by making it overrideable by the page.

Regardless, this should be reverted unless you think you can land a fix before m55 branch.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bd3125aba3a1900c6038b9a4f7e802376820952

commit 8bd3125aba3a1900c6038b9a4f7e802376820952
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Oct 24 21:49:35 2016

Revert of Add the shortcut to toggle high contrast mode to the keyboard overlay (patchset #1 id:20001 of https://codereview.chromium.org/2379673002/ )

Reason for revert:
 http://crbug.com/653330  This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

Original issue's description:
> Add the shortcut to toggle high contrast mode to the keyboard overlay
>
> Screenshot https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LMUpQRG02OXRYU1k/view?usp=sharing
>
> BUG= 644758 
> TEST=open keyboard overlay, hit Ctrl+Alt, and look at the H key.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4
> Cr-Commit-Position: refs/heads/master@{#421587}

TBR=xiyuan@chromium.org,afakhry@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 644758 

Review-Url: https://codereview.chromium.org/2443303002
Cr-Commit-Position: refs/heads/master@{#427163}

[modify] https://crrev.com/8bd3125aba3a1900c6038b9a4f7e802376820952/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/8bd3125aba3a1900c6038b9a4f7e802376820952/chrome/browser/resources/chromeos/keyboard_overlay_data.js
[modify] https://crrev.com/8bd3125aba3a1900c6038b9a4f7e802376820952/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bebe8961758cd40f8abeead4d96ab0d0a9f1628b

commit bebe8961758cd40f8abeead4d96ab0d0a9f1628b
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Oct 25 06:48:44 2016

Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #2 id:20001 of https://codereview.chromium.org/2352213002/ )

Reason for revert:
 http://crbug.com/653330  This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

Original issue's description:
> Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.
>
> BUG= 644758 
>
> Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
> Cr-Commit-Position: refs/heads/master@{#419884}

TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 644758 

Review-Url: https://codereview.chromium.org/2448663002
Cr-Commit-Position: refs/heads/master@{#427293}

[modify] https://crrev.com/bebe8961758cd40f8abeead4d96ab0d0a9f1628b/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/bebe8961758cd40f8abeead4d96ab0d0a9f1628b/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/bebe8961758cd40f8abeead4d96ab0d0a9f1628b/ash/common/accelerators/accelerator_table.h
[modify] https://crrev.com/bebe8961758cd40f8abeead4d96ab0d0a9f1628b/tools/metrics/actions/actions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e951a87b4b5f7f553e1f1dfb678bddce6665be12

commit e951a87b4b5f7f553e1f1dfb678bddce6665be12
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Oct 25 07:06:45 2016

Merge to M55: Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #2 id:20001 of https://codereview.chromium.org/2352213002/ )

Reason for revert:
 http://crbug.com/653330  This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

Original issue's description:
> Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.
>
> BUG= 644758 
>
> Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
> Cr-Commit-Position: refs/heads/master@{#419884}

TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com
BUG= 644758 

Review-Url: https://codereview.chromium.org/2448663002
Cr-Commit-Position: refs/heads/master@{#427293}
(cherry picked from commit bebe8961758cd40f8abeead4d96ab0d0a9f1628b)

Review URL: https://codereview.chromium.org/2448033002 .

Cr-Commit-Position: refs/branch-heads/2883@{#275}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e951a87b4b5f7f553e1f1dfb678bddce6665be12/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/e951a87b4b5f7f553e1f1dfb678bddce6665be12/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/e951a87b4b5f7f553e1f1dfb678bddce6665be12/ash/common/accelerators/accelerator_table.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39618e384be0ffd84c90c2b0c44bad82f7ac1ae7

commit 39618e384be0ffd84c90c2b0c44bad82f7ac1ae7
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Oct 25 16:46:31 2016

Add back high contrast accelerator to actions.xml

It was deleted as part of a revert, but we should keep it in actions.xml
even as the code is in flux.

BUG= 644758 

Review-Url: https://codereview.chromium.org/2445173003
Cr-Commit-Position: refs/heads/master@{#427380}

[modify] https://crrev.com/39618e384be0ffd84c90c2b0c44bad82f7ac1ae7/tools/metrics/actions/actions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e951a87b4b5f7f553e1f1dfb678bddce6665be12

commit e951a87b4b5f7f553e1f1dfb678bddce6665be12
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Oct 25 07:06:45 2016

Merge to M55: Revert of Add Ctrl+Alt+H as global shortcut to toggle high contrast mode. (patchset #2 id:20001 of https://codereview.chromium.org/2352213002/ )

Reason for revert:
 http://crbug.com/653330  This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

Original issue's description:
> Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.
>
> BUG= 644758 
>
> Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
> Cr-Commit-Position: refs/heads/master@{#419884}

TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com
BUG= 644758 

Review-Url: https://codereview.chromium.org/2448663002
Cr-Commit-Position: refs/heads/master@{#427293}
(cherry picked from commit bebe8961758cd40f8abeead4d96ab0d0a9f1628b)

Review URL: https://codereview.chromium.org/2448033002 .

Cr-Commit-Position: refs/branch-heads/2883@{#275}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e951a87b4b5f7f553e1f1dfb678bddce6665be12/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/e951a87b4b5f7f553e1f1dfb678bddce6665be12/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/e951a87b4b5f7f553e1f1dfb678bddce6665be12/ash/common/accelerators/accelerator_table.h

[Automated comment] removing mislabelled merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac88b53fda73316cf2021fc18afbb4e496a4d9c9

commit ac88b53fda73316cf2021fc18afbb4e496a4d9c9
Author: dmazzoni <dmazzoni@chromium.org>
Date: Mon Nov 14 19:21:05 2016

Add Search+Shift+H as global shortcut to toggle high contrast mode.

Originally we landed Ctrl+Alt+H as the shortcut, but this was reverted as
it conflicted with too many apps, and we didn't want it to be overridable.
We're going to migrate all accessibility toggles to Search+Shift+Letter.

This change also adds a notification to aid users who press it by accident.

BUG= 644758 

Review-Url: https://codereview.chromium.org/2487463003
Cr-Commit-Position: refs/heads/master@{#431897}

[modify] https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9/ash/ash_chromeos_strings.grdp
[modify] https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9/ash/common/accelerators/accelerator_table.h
[modify] https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9/ash/common/system/system_notifier.cc
[modify] https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9/ash/common/system/system_notifier.h

 Issue 475150  has been merged into this issue.

 Issue 673180  has been merged into this issue.

Running beta in one of my machines now shows ctrl-alt-h for the hotkey on the hotkey help, but doesn't actually enable anything. 

Version 55.0.2883.82 beta (64-bit)
Platform 8872.67.0 (Official Build) beta-channel samus
ARC Version 3540309
Firmware Google_Samus.6300.174.0

I'll upgrade it to dev and try again.

If ChromeVox Next is enabled, this keybinding is used to navigate to previous heading, so we'ev 2 events for one hotkey. I've file a similar cvox2 bug in the past week or so.

Definitely not using that. High Contrast is the only accessibility option I use.

Looks like a mistake in the overlay. We originally tried to use Ctrl+Alt+H but switched to Search+Shift+H to avoid conflicts. I'll update the overlay.

That still doesn't work on the beta I'm using. (search-shift-h)

Search+Shift+H works in Chrome 56. We reverted Ctrl+Alt+H in Chrome 55 due to conflicts.

Sorry about the confusion. Hope you find it useful once you get Chrome 56.

Verified on 56.0.2924.28/9000.29.0

In ChromeOS 56 beta, the keyboard overlay does not show either shortcut.

We are already receiving user complaints on Chromebook Central concerning this "feature". ("Why is my background black and pictures look funny?")

It is being used to prank others (especially in schools).

The status menu accessibility icon helps, but is easily overlooked.

#CBC-RS/TC-watchlist

One more thing, the move to search-shift-h makes it unusable with an external keyboard plugged in.

I agree with comment #29 that it does not show on the overlay on my build of 56 beta.


Google Chrome	56.0.2924.28 (Official Build) beta (64-bit)
Revision	0
Platform	9000.29.0 (Official Build) beta-channel samus
ARC	3570837
JavaScript	V8 5.6.326.25
Flash	24.0.0.186
User Agent	Mozilla/5.0 (X11; CrOS x86_64 9000.29.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.28 Safari/537.36

Upgraded to dev, still not on the overlay.

Google Chrome	57.0.2951.0 (Official Build) dev (64-bit)
Revision	0
Platform	9086.0.0 (Official Build) dev-channel samus
ARC	3569695
JavaScript	V8 5.7.225
Flash	24.0.0.174
User Agent	Mozilla/5.0 (X11; CrOS x86_64 9086.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2951.0 Safari/537.36

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7ea139838c04b7e254f70debe51e794beda2f1c

commit f7ea139838c04b7e254f70debe51e794beda2f1c
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Dec 21 23:04:48 2016

Toggle High Contrast on Chrome OS should toggle on key down, not key up

This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.

We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.

BUG= 676178 , 644758 
TBR=jamescook

Review-Url: https://codereview.chromium.org/2592223002
Cr-Commit-Position: refs/heads/master@{#440255}

[modify] https://crrev.com/f7ea139838c04b7e254f70debe51e794beda2f1c/ash/common/accelerators/accelerator_table.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b13914173819e4465e4d6b7ef22562db399ee51

commit 0b13914173819e4465e4d6b7ef22562db399ee51
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Jan 06 17:46:23 2017

Toggle High Contrast on Chrome OS should toggle on key down, not key up

This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.

We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.

BUG= 676178 , 644758 
TBR=jamescook

Review-Url: https://codereview.chromium.org/2592223002
Cr-Commit-Position: refs/heads/master@{#440255}
(cherry picked from commit f7ea139838c04b7e254f70debe51e794beda2f1c)

Review-Url: https://codereview.chromium.org/2616113002 .
Cr-Commit-Position: refs/branch-heads/2924@{#687}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/0b13914173819e4465e4d6b7ef22562db399ee51/ash/common/accelerators/accelerator_table.cc

re comment #30: with an external keyboard connected the "windows" or "command" or other special os key will function the same as the search key.

re comment #29; what would you suggest to make it more visible/recoverable?

re #31:  issue 676510  is for the missing keyboard overlay entry

re comment #34: My suggestions for visibility:

Once the notification has been dismissed, the Accessibility icon (little person) is very small and easily overlooked. Make it bigger.

The actual Notification popup is nice, but Notifications are being turned off by many users who find them intrusive. Without Notification, the icons need to be more noticeable.

Users do not seem to be finding the Accessibility section of the status area. 

The status area icons are not documented in the Help system.

The new update icon + is very hard to see on a 1920x1080 screen - the + is so thin that it is fuzzed into the white circle. Once the Status menu is opened, the update icon is still an up-arrow. Make them match. + or up-arrow

A mouse-over popup for the status icons would be a great help for users coming across an unfamiliar icon.

Many Accessibility features are missing from the status area Accessibility menu

<<The status area icons are not documented in the Help system.>> Also, many users run wiht the bar hidden.

Re: #37 Good point on the lack of documentation.  I've filed bug 679454 to track fixing that.

Re: #36: 
* Making the icon bigger is tough. The system tray icons are all the same size.
* Most users shouldn't need to go to the accessibility area. There's a difficult balance to strike between providing the assistive tech we need to for our users, and not having users who DON'T need that tech get derailed by it. We need to keep working on it.
* Good point on documentation. Those icons should be documented.
* I agree on the new update icon. It seems smaller than it should be and less clear. See  bug 679459 . As for 1920x1080 displays, we recommend setting 1536x864 resolution to compensate for size issues.
* Mouseover could be helpful, but breaks down in touch and accessibility use cases.
* The shorter list of accessibility features in the system tray is intentional. Trying to include them all would never scale.

Re: #38 Icon size that we are mentioning should really be called icon thickness or some other term. Understood the the icons are physically the same overall size, but the little man and the new update icon have some very thin and detailed design elements that are difficult to see.

I have a 15" screen on my Acer C910 - the UI elements are perfectly sized and the font characters are easily readable on a 15" display -- except for the update + and the little man.