Skia perf bug in M54 |
|||
Issue descriptionThe Skia CL https://codereview.chromium.org/2222083004/ (Create blurred RRect mask on GPU (rather than uploading it)) introduced a bug (skbug.com/5734) in the creation of blurred roundrects. It can cause some buggy behavior in that blurs of large roundrects can/will consume a lot of VRAM (and thus impact performance and stability). This was fixed, in Skia, in https://codereview.chromium.org/2296193005/ (Add a makeDrawContextWithFallback that handles config fallback) but that change is a bit large for a cherry pick. It is proposed that a subset - https://codereview.chromium.org/2316153002/ (Cherry pick fix for skbug.com/5734 to M54) - be cherry picked instead.
,
Sep 7 2016
Err, s/release blockers/merge requests.
,
Sep 8 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 8 2016
Could you please confirm whether this change is baked/verified in Canary and safe to merge?If yes, merge your change to M54 (branch: 2840) so that we could take this for next Beta Release.
,
Sep 9 2016
Well, the Skia CL https://codereview.chromium.org/2296193005/ (Add a makeDrawContextWithFallback that handles config fallback) has baked for a while in Canary. The actual CL I'm proposing to cherry pick (https://codereview.chromium.org/2316153002/) is a reduced version, since the CL in ToT is probably too extensive to cherry pick.
,
Sep 12 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 13 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by amineer@chromium.org
, Sep 7 2016