arc: Crash OptIn flow and deferred Arc launcher in case of multi-user. |
||||||||||||
Issue descriptionInner bug: b/31154158 Using deferred launcher for Arc app and OptIn flow crash in multi-user environment if secondary user is active. reportid: 0cbb686100000000
,
Sep 8 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/198c86796d5ee15598323b871061536ffd4d1e27 commit 198c86796d5ee15598323b871061536ffd4d1e27 Author: khmel <khmel@chromium.org> Date: Fri Sep 09 21:21:36 2016 [Merge-M54] arc: Disable shelf item creation when secondary user is active. This CL prevents appearing an item on the shelf when Arc app gets active during the secondary user session. BUG=b/31154158 BUG= 644751 BUG=642649 TEST=Manually on device TEST=Added intial unit_test coverage for Arc multi-user TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2325743002 Cr-Commit-Position: refs/heads/master@{#417434} (cherry picked from commit b70099aa14e69cb392d598768807cdb677a67dae) Review-Url: https://codereview.chromium.org/2327203002 Cr-Commit-Position: refs/branch-heads/2840@{#283} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
,
Sep 9 2016
,
Sep 10 2016
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
,
Sep 14 2016
Crash iD -d30b2af500000000 Still seeing crash on 54.0.2840.24/8743.25.0 samus.Need to Merge to 54
,
Sep 14 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 14 2016
Seeing them on M55 too crash ID- 65feddee00000000
,
Sep 18 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38d6e1d0045bbaed50e7730b0c1c25842e41c395 commit 38d6e1d0045bbaed50e7730b0c1c25842e41c395 Author: khmel <khmel@chromium.org> Date: Wed Sep 21 20:33:20 2016 [Merge-M54] arc: Prevent showing Arc app window for secondary user profile. Arc has a limitation to be visible for primary profile only. However, there are situations when Arc task can be started while the secondary profile is shown. Before this led to case when Arc window was shown, which is unexpected. This CL fixes this issue and prevents showing Arc window for non-primary profiles. Test=Manually on the device. Start Arc app in deferred mode and switch to the secondary profile fast. Arc app is started but window is not shown. Switch back to primary profile and window is automatically restored there. BUG=b/31500778 BUG= 647379 BUG= 644751 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2345043002 Cr-Commit-Position: refs/heads/master@{#419497} (cherry picked from commit a4d9c53e0ca156489f3a9b970925594786bab1c0) Review-Url: https://codereview.chromium.org/2361573002 Cr-Commit-Position: refs/branch-heads/2840@{#474} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc [modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48119a2f6a1e687a97a30299db599acce7520a91 commit 48119a2f6a1e687a97a30299db599acce7520a91 Author: khmel <khmel@chromium.org> Date: Wed Sep 21 21:57:26 2016 [Merge-M54] arc: Support Arc window showing/hiding on a user's profile switch. This fixes several cases when multi-user manager and shelf controller is unable to restore Arc window correctly when the user changes his profile. BUG=b/31493349 TEST=Manually on a device. Arc app windows automatically restored when the user switch backs to main profile. BUG= 644751 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2339313002 Cr-Commit-Position: refs/heads/master@{#418905} (cherry picked from commit 6f385b640644bf1cf3c132d5cae98f347c016606) Review-Url: https://codereview.chromium.org/2356213003 Cr-Commit-Position: refs/branch-heads/2840@{#478} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/48119a2f6a1e687a97a30299db599acce7520a91/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/48119a2f6a1e687a97a30299db599acce7520a91/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
,
Sep 21 2016
,
Oct 5 2016
,
Oct 6 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/198c86796d5ee15598323b871061536ffd4d1e27 commit 198c86796d5ee15598323b871061536ffd4d1e27 Author: khmel <khmel@chromium.org> Date: Fri Sep 09 21:21:36 2016 [Merge-M54] arc: Disable shelf item creation when secondary user is active. This CL prevents appearing an item on the shelf when Arc app gets active during the secondary user session. BUG=b/31154158 BUG= 644751 BUG=642649 TEST=Manually on device TEST=Added intial unit_test coverage for Arc multi-user TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2325743002 Cr-Commit-Position: refs/heads/master@{#417434} (cherry picked from commit b70099aa14e69cb392d598768807cdb677a67dae) Review-Url: https://codereview.chromium.org/2327203002 Cr-Commit-Position: refs/branch-heads/2840@{#283} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h [modify] https://crrev.com/198c86796d5ee15598323b871061536ffd4d1e27/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38d6e1d0045bbaed50e7730b0c1c25842e41c395 commit 38d6e1d0045bbaed50e7730b0c1c25842e41c395 Author: khmel <khmel@chromium.org> Date: Wed Sep 21 20:33:20 2016 [Merge-M54] arc: Prevent showing Arc app window for secondary user profile. Arc has a limitation to be visible for primary profile only. However, there are situations when Arc task can be started while the secondary profile is shown. Before this led to case when Arc window was shown, which is unexpected. This CL fixes this issue and prevents showing Arc window for non-primary profiles. Test=Manually on the device. Start Arc app in deferred mode and switch to the secondary profile fast. Arc app is started but window is not shown. Switch back to primary profile and window is automatically restored there. BUG=b/31500778 BUG= 647379 BUG= 644751 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2345043002 Cr-Commit-Position: refs/heads/master@{#419497} (cherry picked from commit a4d9c53e0ca156489f3a9b970925594786bab1c0) Review-Url: https://codereview.chromium.org/2361573002 Cr-Commit-Position: refs/branch-heads/2840@{#474} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc [modify] https://crrev.com/38d6e1d0045bbaed50e7730b0c1c25842e41c395/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48119a2f6a1e687a97a30299db599acce7520a91 commit 48119a2f6a1e687a97a30299db599acce7520a91 Author: khmel <khmel@chromium.org> Date: Wed Sep 21 21:57:26 2016 [Merge-M54] arc: Support Arc window showing/hiding on a user's profile switch. This fixes several cases when multi-user manager and shelf controller is unable to restore Arc window correctly when the user changes his profile. BUG=b/31493349 TEST=Manually on a device. Arc app windows automatically restored when the user switch backs to main profile. BUG= 644751 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2339313002 Cr-Commit-Position: refs/heads/master@{#418905} (cherry picked from commit 6f385b640644bf1cf3c132d5cae98f347c016606) Review-Url: https://codereview.chromium.org/2356213003 Cr-Commit-Position: refs/branch-heads/2840@{#478} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/48119a2f6a1e687a97a30299db599acce7520a91/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/48119a2f6a1e687a97a30299db599acce7520a91/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 8 2016