Investigate if RenderWidgetHostViewChildFrame::GetNativeView() can always return non-null. |
||
Issue descriptionAt present, consumers of RenderWidgetHostViewBase::GetNativeView() generally assume a non-null return value for this function. However, at present RenderWidgetHostViewChildFrame::GetNativeView() may return null. It seems like we need to either (1) modify consumers' behaviour, or (2) make sure that all versions of this function (almost?) always return non-null. Since RWHVCF will be sharing a NativeView with its RootRenderWidgetHostView, there *may* be cases where we run into conflicts (e.g. one consumer wants to change a setting on the window in a manner that conflicts with another consumer's settings on the same window via a different view. In this case it would seem sensible for the RWHVCF consumer to always default to the parent view's settings, but we should find out if this even happens).
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd1a8a3acc82119847fd1ae38b50c84d34400c0d commit fd1a8a3acc82119847fd1ae38b50c84d34400c0d Author: W. James MacLean <wjmaclean@chromium.org> Date: Mon Sep 12 14:19:30 2016 Check for null return from GetNativeView(). At present many (all?) consumers of RenderWidgetHostViewBase::GetNativeView() assume it always returns non- null, but this may not be a safe assumption if the view is a RenderWidgetHostViewChildFrame. This CL temporarily fixes a crash when ChromeOS hits this case, while we review the behaviour of the consumers of this function, and while we review the implementation in RenderWidgetHostViewChildFrame. BUG=644294, 644726 Review-Url: https://codereview.chromium.org/2322513002 Cr-Commit-Position: refs/heads/master@{#417288} (cherry picked from commit 079861f265916d3b9d6323a2f4cf07cdba864a05) Review URL: https://codereview.chromium.org/2337483002 . Cr-Commit-Position: refs/branch-heads/2840@{#298} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/fd1a8a3acc82119847fd1ae38b50c84d34400c0d/ui/keyboard/content/keyboard_ui_content.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd1a8a3acc82119847fd1ae38b50c84d34400c0d commit fd1a8a3acc82119847fd1ae38b50c84d34400c0d Author: W. James MacLean <wjmaclean@chromium.org> Date: Mon Sep 12 14:19:30 2016 Check for null return from GetNativeView(). At present many (all?) consumers of RenderWidgetHostViewBase::GetNativeView() assume it always returns non- null, but this may not be a safe assumption if the view is a RenderWidgetHostViewChildFrame. This CL temporarily fixes a crash when ChromeOS hits this case, while we review the behaviour of the consumers of this function, and while we review the implementation in RenderWidgetHostViewChildFrame. BUG=644294, 644726 Review-Url: https://codereview.chromium.org/2322513002 Cr-Commit-Position: refs/heads/master@{#417288} (cherry picked from commit 079861f265916d3b9d6323a2f4cf07cdba864a05) Review URL: https://codereview.chromium.org/2337483002 . Cr-Commit-Position: refs/branch-heads/2840@{#298} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/fd1a8a3acc82119847fd1ae38b50c84d34400c0d/ui/keyboard/content/keyboard_ui_content.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 8 2016