Harmony: combobox text looks wrong |
|||
Issue descriptionThe text for comboboxes looks very wrong. Attached: 1) Screenshot of how the text looks now 2) Screenshot of what happens with an extra FillRect(..., SK_ColorWHITE) hacked in before DrawStringRect().
,
Sep 7 2016
Over to you for the text-onto-layer stuff.
,
Sep 7 2016
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/535dfe7eacd0c1ac003859cf18a81297f508ad5a commit 535dfe7eacd0c1ac003859cf18a81297f508ad5a Author: estade <estade@chromium.org> Date: Wed Sep 07 22:23:13 2016 More Harmony combobox/textfield updates: Textfields: - handle disabled state for text, border Comboboxes: - update enabled text color (matches textfield) - handle disabled state for text, arrow, border (matches textfield) - draw a solid background so that subpixel aa works BUG= 644709 , 635164 , 635160 Review-Url: https://codereview.chromium.org/2319193002 Cr-Commit-Position: refs/heads/master@{#417093} [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/native_theme/common_theme.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/combobox/combobox.h [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/focusable_border.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/examples/textfield_example.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/examples/textfield_example.h
,
Sep 7 2016
should be fixed
,
Sep 9 2016
,
Sep 12 2016
Issue 645691 has been merged into this issue.
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e41d4becf20af46ef3c392a199f16fa9c987ddf commit 7e41d4becf20af46ef3c392a199f16fa9c987ddf Author: ellyjones <ellyjones@chromium.org> Date: Fri Sep 16 19:18:42 2016 views: use MD padding for combobox This change was originally part of https://codereview.chromium.org/2317033002, but fell on the floor. Oops! BUG= 644709 Review-Url: https://codereview.chromium.org/2342783004 Cr-Commit-Position: refs/heads/master@{#419243} [modify] https://crrev.com/7e41d4becf20af46ef3c392a199f16fa9c987ddf/ui/views/controls/combobox/combobox.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, Sep 7 2016