New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 64470 link

Starred by 22 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

WebSocket: Implement new WebSocket protocol

Project Member Reported by yutak@chromium.org, Nov 26 2010

Issue description

http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-03

This will cause (intentional) compatibility break with older servers.
 

Comment 1 by yutak@chromium.org, Nov 26 2010

Filed at WebKit bugzilla:
https://bugs.webkit.org/show_bug.cgi?id=50099

Comment 2 by kerz@chromium.org, Dec 9 2010

Labels: -Mstone-10 MovedFrom-10 Mstone-11
P2 bugs with an owner that are not marked as started are being automatically moved to mstone:11.

Comment 3 by yutak@chromium.org, Mar 1 2011

Labels: -Mstone-11 Mstone-12
Summary: WebSocket: Implement new WebSocket protocol
Punting to M-12, as protocol discussion is still ongoing in IETF hybi list.
In the mean time:
http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-06
I'm posting it just for the record as I believe anyone interested is up-to-date.
Can't wait for version 12 to hit the chrome-dev channel ;)

BTW - is there a simple, built-in way to check which protocol version is implemented in the browser I'm using (chrome 11.0.686.1)?

Comment 6 by yutak@chromium.org, Apr 15 2011

Labels: -Mstone-12 Mstone-13
This is going to be in M-13.
Project Member

Comment 7 by bugdroid1@chromium.org, May 6 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=84427

------------------------------------------------------------------------
r84427 | yutak@chromium.org | Fri May 06 03:14:28 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_handshake_handler.cc?r1=84427&r2=84426&pathrev=84427
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_job.cc?r1=84427&r2=84426&pathrev=84427
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_handshake_handler_unittest.cc?r1=84427&r2=84426&pathrev=84427
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_handshake_handler.h?r1=84427&r2=84426&pathrev=84427

Accept new WebSocket handshake format (hybi-04 and later).

To update WebSocket protocol implementation in WebKit,
WebSocketRequestHandshakeHandler and WebSocketResponseHandler need to be able
to understand both old handshake (hybi-03 and prior, including hixie-76) and
new handshake (hybi-04 and later).

BUG= 64470 
TEST=net_unittests --gtest_filter="WebSocketHandshake*HandlerTest.*"


Review URL: http://codereview.chromium.org/6823075
------------------------------------------------------------------------

Comment 8 Deleted

Comment 9 by fre...@gmail.com, May 31 2011

Working on a Mojolicious site that supports ietf-07 (hybi-07?) but chrome doesn't appear to co-operate - The server registers the websocket connection but chrome never completes the connection it seems.

I'm using "13.0.781.0 (Developer Build 87259 Linux)" which I downloaded today - there are no warnings or errors which make this any easier to diagnose.

Knowing what version of the protocol Chrome supports (and getting a console error/warning) would be extremely useful

Comment 10 by yutak@google.com, May 31 2011

The new protocol is not implemented yet. Hixie's draft 76 is what we support right now.

Comment 11 by ukai@chromium.org, May 31 2011

To diagnose, you can use chrome://net-internals/#events, and filter by "ws" or target url. you'll see what handshake request chrome sent and what handshake response chrome received.

Labels: -Mstone-13 Mstone-14 MovedFrom-13
Moving !type=meta|regression and !releaseblocker to next mstone
I am wondering whether and when the hybi-07 will be implemented so that Chrome sends  handshakes in that new format. Is there any hint as to when this might be implemented?
FYI, the latest one is hybi-10.

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 22 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=93578

------------------------------------------------------------------------
r93578 | yutak@chromium.org | Fri Jul 22 01:24:47 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.h?r1=93578&r2=93577&pathrev=93578
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?r1=93578&r2=93577&pathrev=93578
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/websocket/test.html?r1=93578&r2=93577&pathrev=93578
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/test/worker_uitest.cc?r1=93578&r2=93577&pathrev=93578

Enable hybi WebSocket protocol by default.

This CL enables the new WebSocket protocol by overriding the value of WebCore::Settings::useHixie76WebSocketProtocol() to false.

It is known that WebSocket instances initialized in worker context use the old hixie76 protocol even after this change is applied (see https://bugs.webkit.org/show_bug.cgi?id=64852). I'm going to take care of it after this CL is committed.

BUG= 64470 
TEST=none


Review URL: http://codereview.chromium.org/7462009
------------------------------------------------------------------------

Comment 16 by k...@google.com, Jul 28 2011

Labels: -Mstone-14 Mstone-15 MovedFrom-14
Punting out non-critical bugs.  Please move back to 14 if you believe this was done in error.

Comment 17 by yutak@chromium.org, Jul 28 2011

Labels: -Feature-WebSocket -Mstone-15 -MovedFrom-14 WebKit-WebSockets Mstone-14
Status: Fixed
Actually, hybi-10 handshake and framing is implemented and will be shipped with M14.
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-WebKit -WebKit-WebSockets -WebKit-Core -Mstone-14 Cr-Content Cr-Content-WebSockets Cr-Content-Core M-14
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-WebSockets Cr-Blink-WebSockets

Comment 23 by tkent@chromium.org, Nov 27 2015

Labels: Cr-Blink-Network-WebSockets

Comment 24 by tkent@chromium.org, Nov 27 2015

Labels: -Cr-Blink-WebSockets

Sign in to add a comment