GOOPDATE_E_APP_USING_EXTERNAL_UPDATER errors caused by Chrome |
|||||
Issue descriptionChrome's on-demand update check code was moved from the FILE thread to the blocking pool in r409468. While it appeared to work, I discovered that Chrome could keep some objects alive in Google Update's out-of-proc COM server longer than intended. These result in GOOPDATE_E_APP_USING_EXTERNAL_UPDATER errors for both on-demand and scheduled updates. The root of the problem is that threads in Chrome's blocking pool are initialized into COM STAs, yet they do not pump Windows messages. This is a requirement for using the COM Global Interface Table. I am reverting the change that caused this. The revert will need to be merged back to M54.
,
Sep 7 2016
Will request a merge once this ships and is verified.
,
Sep 9 2016
Verified in 55.0.2854.2 (Official Build) canary (64-bit). Requesting merge to M54. Thanks.
,
Sep 9 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b commit 28da2248ab0ce98128a63fb2f2a416ee2a6eb11b Author: Greg Thompson <grt@chromium.org> Date: Fri Sep 09 11:50:35 2016 Revert "Move on-demand update checks from the FILE thread to the blocking pool." This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new code in the aforementioned commit). Reason for revert: Threads in the blocking pool do not pump Windows messages, which is required for correct functioning of the global interface table; see https://crbug.com/644687 . BUG= 2462 , 644687 TBR=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2318073002 Cr-Commit-Position: refs/heads/master@{#416918} (cherry picked from commit 9f391dd808620d168b5ef7587799c26d734b324e) TBR=grt@chromium.org Review URL: https://codereview.chromium.org/2322153003 . Cr-Commit-Position: refs/branch-heads/2840@{#266} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/google/google_update_win.cc [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/google/google_update_win.h [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/google/google_update_win_unittest.cc [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/ui/webui/help/version_updater_win.cc [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/ui/webui/help/version_updater_win.h
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b commit 28da2248ab0ce98128a63fb2f2a416ee2a6eb11b Author: Greg Thompson <grt@chromium.org> Date: Fri Sep 09 11:50:35 2016 Revert "Move on-demand update checks from the FILE thread to the blocking pool." This reverts commit 12cdde78e334c9380bb0b07a85a1198d0094cfe0 (and a80b84bf1ce305677f7eb99f0a9dbbff8904aa2f since it only impacted the new code in the aforementioned commit). Reason for revert: Threads in the blocking pool do not pump Windows messages, which is required for correct functioning of the global interface table; see https://crbug.com/644687 . BUG= 2462 , 644687 TBR=pkasting@chromium.org Review-Url: https://codereview.chromium.org/2318073002 Cr-Commit-Position: refs/heads/master@{#416918} (cherry picked from commit 9f391dd808620d168b5ef7587799c26d734b324e) TBR=grt@chromium.org Review URL: https://codereview.chromium.org/2322153003 . Cr-Commit-Position: refs/branch-heads/2840@{#266} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/google/google_update_win.cc [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/google/google_update_win.h [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/google/google_update_win_unittest.cc [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/ui/webui/help/version_updater_win.cc [modify] https://crrev.com/28da2248ab0ce98128a63fb2f2a416ee2a6eb11b/chrome/browser/ui/webui/help/version_updater_win.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2016