Add support for 384kHz audio devices
Reported by
szd...@gmail.com,
Sep 7 2016
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 Example URL: Steps to reproduce the problem: 1. Install a 384kHz hw audio device 2. AudioContext creation will fail with the error message: NotSupportedError: Failed to construct 'AudioContext': The hardware sample rate provided (384000) is outside the range [3000, 192000]. What is the expected behavior? What went wrong? Maximum sample rate currently supported is 192kHz. Did this work before? N/A Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? N/A Chrome version: 52.0.2743.116 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 20.0 r0
,
Sep 8 2016
We already have support for this in <video>, so I'm not sure why it's not working with WebAudio.
,
Sep 8 2016
This check was added in issue 549577. Easy enough to widen. Is there a current upper limit for video? If so, is there a way to query that?
,
Sep 8 2016
media/base/limits.h has ours.
,
Sep 8 2016
Based on the comments in that file, I think we'll just hardwire to 384 instead of trying to query it. (Can't include media/base/limits.h into blink, I think.)
,
Sep 26 2016
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b907faaeab1c40d2081e951a198248e32fdf6242 commit b907faaeab1c40d2081e951a198248e32fdf6242 Author: rtoy <rtoy@chromium.org> Date: Wed Oct 12 18:38:32 2016 Support sample rates up to 384 kHz. Allow AudioContext and OfflineAudioContext to support sample rates up to 384 kHz. The <video> tag supports this already. This also means that AudioBuffer's also support these rates. Update tests to test for this. BUG= 644683 TEST=dom-exceptions.html, offlineaudiocontext-constructor.html Review-Url: https://codereview.chromium.org/2334773003 Cr-Commit-Position: refs/heads/master@{#424801} [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor.html [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/third_party/WebKit/Source/platform/audio/AudioUtilities.cpp [modify] https://crrev.com/b907faaeab1c40d2081e951a198248e32fdf6242/tools/metrics/histograms/histograms.xml
,
Oct 17 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yini...@chromium.org
, Sep 8 2016Components: -Internals>Media Internals>Media>Audio