New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644668 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Integer-overflow in ratio

Project Member Reported by ClusterFuzz, Sep 7 2016

Issue description

Cc: mmoroz@chromium.org deanm@chromium.org kcc@chromium.org tc@google.com aizatsky@chromium.org
Owner: pkasting@chromium.org
Looks like an initial author of that code (tc@) is not working on Chrome.

dmg_fp has no OWNERS.

pkasting@ and deanm@, you made some changes there. Could you please help to find an owner for the issue?

Owner: scottmg@chromium.org
We want to just kill dmg_fp, see bug 593512 among others.

We are getting a rapidly-increasing number of fuzzing reports about it.

I would support duping everything into one "kill dmg_fp" bug and then actually killing it.  Hopefully strtod() is good enough by now.
Project Member

Comment 3 by ClusterFuzz, Sep 25 2016

ClusterFuzz has detected this issue as fixed in range 420821:420836.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5822270557913088

Fuzzer: libfuzzer_string_to_int_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  ratio
  dmg_fp::strtod
  base::StringToDouble
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=416034:416198
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=420821:420836

Minimized Testcase (2.48 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97A0zil3IIGxlwpAVAaeLU4Zu7Atfkm-wBuavcIx2Gd5ZZOZyt4hkcUXVHUC-txEX7-2Jp2ht60HjYAj257gFl3VgTITDEIhSCbjNqFKJIk5LiVJiDnYE5rbdjvKCVZuHEAmyGsy-DH4hU2ZGlVDGESVlWV9w?testcase_id=5822270557913088

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Sep 25 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 5 by kcwu@chromium.org, Sep 27 2016

Cc: scottmg@chromium.org
Owner: kcwu@chromium.org
This should be fixed by http://crrev.com/2364123002
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment