Record shutdown type UMA |
||
Issue descriptionReadLastShutdownFile records UMA histograms Shutdown.window_close.time and Shutdown.end_session.time which can be used to figure out how frequently Chrome is performing unclean shutdown triggered by WM_ENDSESSION on Windows. (https://cs.chromium.org/chromium/src/chrome/browser/browser_shutdown.cc?q=Shutdown.%25s&sq=package:chromium&dr=C&l=276) However, currently the UMA is not correctly recorded because prefs::kShutdownType is not set when handling WM_ENDSESSION. We should fix this to see how often unclean shutdown is performed on Windows.
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc347b79180cd2880ee49067abb295a00ab3d7b6 commit dc347b79180cd2880ee49067abb295a00ab3d7b6 Author: hashimoto <hashimoto@chromium.org> Date: Fri Sep 16 07:23:40 2016 Record shutdown type UMA To investigate how frequently unclean shutdown is performed. Start recording a new UMA Shutdown.ShutdownType. Update prefs::kShutdownType when Chrome is performing unclean shutdown with SessionEnding(). BUG= 644649 Review-Url: https://codereview.chromium.org/2318373003 Cr-Commit-Position: refs/heads/master@{#419123} [modify] https://crrev.com/dc347b79180cd2880ee49067abb295a00ab3d7b6/chrome/browser/browser_shutdown.cc [modify] https://crrev.com/dc347b79180cd2880ee49067abb295a00ab3d7b6/chrome/browser/browser_shutdown.h [modify] https://crrev.com/dc347b79180cd2880ee49067abb295a00ab3d7b6/chrome/browser/lifetime/application_lifetime.cc [modify] https://crrev.com/dc347b79180cd2880ee49067abb295a00ab3d7b6/tools/metrics/histograms/histograms.xml
,
Sep 20 2016
CL was landed. We'll be able to get the stable channel's data after a few months.
,
Sep 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f066d6b7f0621db757b9a4c7627fe8bfe5737c9a commit f066d6b7f0621db757b9a4c7627fe8bfe5737c9a Author: hashimoto <hashimoto@chromium.org> Date: Wed Sep 21 05:02:21 2016 Add Shutdown time histograms to histograms.xml BUG= 644649 Review-Url: https://codereview.chromium.org/2348843002 Cr-Commit-Position: refs/heads/master@{#419976} [modify] https://crrev.com/f066d6b7f0621db757b9a4c7627fe8bfe5737c9a/tools/metrics/histograms/histograms.xml |
||
►
Sign in to add a comment |
||
Comment 1 by hashimoto@chromium.org
, Sep 7 2016