CQ: Reload project config when it changes |
|||||
Issue descriptionCurrently it only loads it once on startup. When we move CQ to be a long-running process this won't work.
,
Sep 8 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/7897bed33e4452c9788c75b20c619c56a90d3f9d commit 7897bed33e4452c9788c75b20c619c56a90d3f9d Author: David Sansome <dsansome@google.com> Date: Thu Sep 08 07:44:51 2016
,
Sep 8 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/8702aec17570b9a4aac407df861392e166afa4b8 commit 8702aec17570b9a4aac407df861392e166afa4b8 Author: dsansome <dsansome@google.com> Date: Thu Sep 08 08:36:12 2016
,
Sep 8 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/2d2d2238ff4353b3e7cdc80db8aab0ae80f9120e commit 2d2d2238ff4353b3e7cdc80db8aab0ae80f9120e Author: David Sansome <dsansome@google.com> Date: Thu Sep 08 09:04:15 2016
,
Sep 9 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/3d6220976d958d44ea4bdcfed0c6cb9539732ace commit 3d6220976d958d44ea4bdcfed0c6cb9539732ace Author: dsansome <dsansome@google.com> Date: Fri Sep 09 00:31:31 2016
,
Sep 9 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/6a2eea7d7bdab136db6c070717725750dce2cdc7 commit 6a2eea7d7bdab136db6c070717725750dce2cdc7 Author: dsansome <dsansome@google.com> Date: Fri Sep 09 01:42:00 2016
,
Sep 20 2016
,
Sep 20 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/1adc013790ad3d75defdafb841073225a19489b1 commit 1adc013790ad3d75defdafb841073225a19489b1 Author: dsansome <dsansome@google.com> Date: Tue Sep 20 12:12:51 2016
,
Oct 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/87be6bf7260d1e12168d2beb3f032664d4110624 commit 87be6bf7260d1e12168d2beb3f032664d4110624 Author: dsansome <dsansome@google.com> Date: Tue Oct 11 04:54:22 2016
,
Oct 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/58cbdaedfbe863bb06449589deeabb012fd054ea commit 58cbdaedfbe863bb06449589deeabb012fd054ea Author: dsansome <dsansome@google.com> Date: Tue Oct 11 05:24:54 2016
,
Oct 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/58cbdaedfbe863bb06449589deeabb012fd054ea commit 58cbdaedfbe863bb06449589deeabb012fd054ea Author: dsansome <dsansome@google.com> Date: Tue Oct 11 05:24:54 2016
,
Oct 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/58cbdaedfbe863bb06449589deeabb012fd054ea commit 58cbdaedfbe863bb06449589deeabb012fd054ea Author: dsansome <dsansome@google.com> Date: Tue Oct 11 05:24:54 2016
,
Jan 18 2017
Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?
,
Jan 23 2017
,
Mar 2 2017
IMO, in practice CQ config changes rarely, so adding detection of the change + suicide in CQ process itself will achieve the desired goal without huge refactoring.
,
May 19 2017
Tandrii is fixing this by making CQ commit suicide when the config changes, so it can be restarted by service manager.
,
May 24 2017
https://chrome-internal-review.googlesource.com/379209 has added suicide argument.
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/19733aa8af0262fabad6decf9ea4a3b46c44c4a2 commit 19733aa8af0262fabad6decf9ea4a3b46c44c4a2 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 10:30:09 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/91903b11b0f4ea672856ee89476909979f3e7ad4 commit 91903b11b0f4ea672856ee89476909979f3e7ad4 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 13:10:31 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/896364b937e5adad545b748cf9d94c5ac7488c48 commit 896364b937e5adad545b748cf9d94c5ac7488c48 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 13:20:32 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/d45835f056abb0551f370de50dde235a04ec39a1 commit d45835f056abb0551f370de50dde235a04ec39a1 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 13:55:55 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/d45835f056abb0551f370de50dde235a04ec39a1 commit d45835f056abb0551f370de50dde235a04ec39a1 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 13:55:55 2017
,
May 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/79adb686bb247919edcb3743cbe1ed620251cd88 commit 79adb686bb247919edcb3743cbe1ed620251cd88 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 14:08:09 2017
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/071d58a5f46ffec276de2bed8ce49dbd66efdc87 commit 071d58a5f46ffec276de2bed8ce49dbd66efdc87 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 14:11:33 2017 CQ: poke cq.config to test reloading of CQ config. Bug: 644620 Change-Id: Ia12c47029288f389393e2aece8b561cff6baf08f Reviewed-on: https://chromium-review.googlesource.com/513928 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/071d58a5f46ffec276de2bed8ce49dbd66efdc87/infra/config/cq.cfg
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/acdb8009a0e087b6e869ab19d69ca705dca7d19e commit acdb8009a0e087b6e869ab19d69ca705dca7d19e Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 24 14:20:20 2017 Revert "CQ: poke cq.config to test reloading of CQ config." This reverts commit 071d58a5f46ffec276de2bed8ce49dbd66efdc87. Reason for revert: poke again! Original change's description: > CQ: poke cq.config to test reloading of CQ config. > > Bug: 644620 > Change-Id: Ia12c47029288f389393e2aece8b561cff6baf08f > Reviewed-on: https://chromium-review.googlesource.com/513928 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > TBR=tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 644620 Change-Id: Ica2946b8263fbac268e89172cee2ac77895d872b Reviewed-on: https://chromium-review.googlesource.com/514102 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/acdb8009a0e087b6e869ab19d69ca705dca7d19e/infra/config/cq.cfg
,
May 24 2017
So, I've verified that CQ luci config reloading works as intended. The delays within 20 seconds every 5 minutes on current single canary test cq: http://shortn/_W105Ty8zdA (also attached) but it's OK.
,
May 26 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/f1fa57f75786dee3269d32643bec9f217b0a9b5f commit f1fa57f75786dee3269d32643bec9f217b0a9b5f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri May 26 09:08:03 2017
,
May 29 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/f64669b76e724a37ab1aa8f9be1cea79291bacf7 commit f64669b76e724a37ab1aa8f9be1cea79291bacf7 Author: Andrii Shyshkalov <tandrii@google.com> Date: Mon May 29 08:45:51 2017 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 8 2016