New issue
Advanced search Search tips

Issue 644614 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"DesktopMediaPickerViewsTest.DoneCallbackCalledOnOkButtonPressed" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 7 2016

Issue description

"DesktopMediaPickerViewsTest.DoneCallbackCalledOnOkButtonPressed" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj9EZXNrdG9wTWVkaWFQaWNrZXJWaWV3c1Rlc3QuRG9uZUNhbGxiYWNrQ2FsbGVkT25Pa0J1dHRvblByZXNzZWQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: msw@chromium.org
Assigning to msw@ for triaging. I think "base::RunLoop().RunUntilIdle();" in the end makes the test to time out.

Comment 2 by msw@chromium.org, Sep 7 2016

Owner: qiangchen@chromium.org
Please use source history to assign a relevant owner, thanks. Passing to qiangchen@
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Sep 16 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "DesktopMediaPickerViewsTest.DoneCallbackCalledOnOkButtonPressed". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj9EZXNrdG9wTWVkaWFQaWNrZXJWaWV3c1Rlc3QuRG9uZUNhbGxiYWNrQ2FsbGVkT25Pa0J1dHRvblByZXNzZWQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Disabling test on Windows. Please re-enable the test once it passes reliably.

Removing Sheriff-Chromium label.
Labels: -Pri-1 Pri-2
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a3cc08db4f53c112bb9161f556e01b09f26c49b

commit 3a3cc08db4f53c112bb9161f556e01b09f26c49b
Author: iclelland <iclelland@chromium.org>
Date: Mon Sep 19 16:00:53 2016

Disabled DesktopMediaPickerViewsTest.DoneCallbackCalledOnOkButtonPressed test on Windows

This test has been flaky for a couple of weeks now. Disabling on
Windows platform until that can be corrected.

TBR=qiangchen@chromium.org
BUG= 644614 

Review-Url: https://codereview.chromium.org/2346253003
Cr-Commit-Position: refs/heads/master@{#419472}

[modify] https://crrev.com/3a3cc08db4f53c112bb9161f556e01b09f26c49b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

Status: Archived (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/257878d4a4463d1491def1b8cbde0049d247961d

commit 257878d4a4463d1491def1b8cbde0049d247961d
Author: Wei Li <weili@chromium.org>
Date: Tue Nov 27 22:18:14 2018

Re-enable DoneCallbackCalledOnOkButtonPressed test

This test was disabled due to flakiness on Windows7 sp1.

BUG= 644614 

Change-Id: Id48da1b956c38681d1aa16d0a8de95155fc875a2
Reviewed-on: https://chromium-review.googlesource.com/c/1345416
Reviewed-by: Qiang Chen <qiangchen@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611368}
[modify] https://crrev.com/257878d4a4463d1491def1b8cbde0049d247961d/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

Sign in to add a comment