New issue
Advanced search Search tips

Issue 644600 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 600469



Sign in to add a comment

Hash-linked comments coloring in Rietveld overrides LGTM; causes unreadable text with "not LGTM"

Project Member Reported by lgar...@chromium.org, Sep 7 2016

Issue description

What steps will reproduce the problem?
(1) Use the "non-deprecated" Rietveld UI
(2) Visit https://codereview.chromium.org/2272793007#msg17

What is the expected output?
Comment #14 and #17 indicate LGTM in the consistent way.

What do you see instead?
For #17, the fact that comment #17 is linked in the URL causes it to be highlighted.
I thought for a moment that Rietveld now detects "LGTM with nits" and marks it as yellow.
But now, the hashlink simply trumps the existing color, and there is no cue to indicate this.

The same also applies to "not LGTM", which would simply be a little confusing, except that the white text color (meant for a red background) now shows up on beige. (not-lgtm.png)
https://codereview.chromium.org/2231383003#msg6

Rare edge cases, but I let no bug go unfiled! ;-)
 
Cc: esprehn@chromium.org
Status: Available (was: Untriaged)
Blockedon: 600469
Status: WontFix (was: Available)
Rietveld is deprecated in favor of Gerrit.

Sign in to add a comment