New issue
Advanced search Search tips

Issue 644597 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 600469



Sign in to add a comment

Rietveld email comment order does not match listing order.

Project Member Reported by lgar...@chromium.org, Sep 7 2016

Issue description

What steps will reproduce the problem?
(1) Use the "non-deprecated" Rietveld UI
(2) Visit https://codereview.chromium.org/2272793007#msg17

What is the expected output?
The comments in the automated email/comment are in the same order as the files.

What do you see instead?
The .h file is before the .cc file in the patch listing.
The .cc file is before the .h file in the emailed comment.

In cases where someone goes through the files in order, comments on something in one file, and then comments on a realization in the other, the realization is emailed before the first comment. This is unexpectedly confusing.
 
Blockedon: 600469
Cc: esprehn@chromium.org
Status: Available (was: Untriaged)
Status: WontFix (was: Available)
Rietveld is deprecated in favor of Gerrit.

Sign in to add a comment