New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644586 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 620549
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

JS-based bold midway through word entry has no effect

Project Member Reported by aelias@chromium.org, Sep 7 2016

Issue description

Split off from http://b/27889099

On https://jsfiddle.net/9n17does with Google Keyboard 5.0+, if you type a few letters in the ContentEditable, press the "Bold" button, then type more letters, the bold state is lost.  This is because Google Keyboard commits text to the entire word each time a letter is added, clobbering the mid-word <b> DOM-node and resetting the style to the beginning of the word.

On the internal bug, we've discussed changing Google Keyboard to commit one letter at a time to avoid this, but yukawa@ opposes this because the Android APIs force a whole-word composition in order to support nonstandard underline colors (because that's a span object starting at the beginning of the word).  So I plan to land a workaround in Blink to detect when the beginning of the IME commit is the same at what was there already, and restrict the write to only the character(s) at the end that actually changed.
 

Comment 1 by aelias@chromium.org, Sep 22 2016

Cc: aelias@chromium.org
Owner: yabinh@chromium.org
I'm not finding the cycles to polish/rebase/write tests for my WIP patch https://codereview.chromium.org/2073863003, and I probably won't have time next week either.  yabinh@, since I see you're about to transition to P2/P3 bugs, could you finish this bug for me?  This is one of the highest priority issues (equal priority to  http://crbug.com/636237 ).  Thanks!

Comment 2 by aelias@chromium.org, Sep 29 2016

Mergedinto: 620549
Status: Duplicate (was: Assigned)

Sign in to add a comment