Add BETA to settings & opt-in strings |
|||||||||||||
Issue descriptionChrome Version : 53 As a follow up to 643816, we need to update some strings to reflect our beta status in M53. We need to: * Add (beta) at the end of header of our Settings section that says "Google Play Store" * Add (beta) to Play Store icon in launcher We should have the beta string already (e.g. in the smartlock section) so we don't need new translation
,
Sep 7 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e10991699b852408f64d9e5195b07b45ebebb202 commit e10991699b852408f64d9e5195b07b45ebebb202 Author: xdai <xdai@chromium.org> Date: Fri Sep 09 18:16:59 2016 [ARC] Add "(beta)" string to Play Store. - Add (beta) at the end of header of chrome://settings section that says "Google Play Store" - Add (beta) to Play Store icon in launcher Note: This change is only for M53 and will be reverted on Tot after being merged to M53. BUG= 644576 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2318333003 Cr-Commit-Position: refs/heads/master@{#417637} [modify] https://crrev.com/e10991699b852408f64d9e5195b07b45ebebb202/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/e10991699b852408f64d9e5195b07b45ebebb202/chrome/browser/ui/webui/options/browser_options_handler.cc
,
Sep 9 2016
,
Sep 9 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5125ea3654f26f88082d118cd714684726b8a1a commit d5125ea3654f26f88082d118cd714684726b8a1a Author: xdai <xdai@chromium.org> Date: Fri Sep 09 20:59:19 2016 [Merge to M53] [ARC] Add "(beta)" string to Play Store. - Add (beta) at the end of header of chrome://settings section that says "Google Play Store" - Add (beta) to Play Store icon in launcher Note: This change is only for M53 and will be reverted on Tot after being merged to M53. BUG= 644576 TBR=xiyuan@chromium.org, dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2318333003 Cr-Commit-Position: refs/heads/master@{#417637} (cherry picked from commit e10991699b852408f64d9e5195b07b45ebebb202) Review URL: https://codereview.chromium.org/2327803003 . Cr-Commit-Position: refs/branch-heads/2785@{#866} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/d5125ea3654f26f88082d118cd714684726b8a1a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/d5125ea3654f26f88082d118cd714684726b8a1a/chrome/browser/ui/webui/options/browser_options_handler.cc
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d972e190a99e96c243d4d8ba421fb61a5c26d4ec commit d972e190a99e96c243d4d8ba421fb61a5c26d4ec Author: xdai <xdai@chromium.org> Date: Fri Sep 09 21:10:07 2016 Revert "[ARC] Add "(beta)" string to Play Store." This reverts commit e10991699b852408f64d9e5195b07b45ebebb202. [ARC] Add "(beta)" string to Play Store. - Add (beta) at the end of header of chrome://settings section that says "Google Play Store" - Add (beta) to Play Store icon in launcher Note: This change is only for M53 and will be reverted on Tot after being merged to M53. BUG= 644576 TBR=xiyuan@chromium.org, dbeam@chromium.org Review URL: https://codereview.chromium.org/2329063002 . Cr-Commit-Position: refs/heads/master@{#417713} [modify] https://crrev.com/d972e190a99e96c243d4d8ba421fb61a5c26d4ec/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/d972e190a99e96c243d4d8ba421fb61a5c26d4ec/chrome/browser/ui/webui/options/browser_options_handler.cc
,
Sep 9 2016
,
Sep 30 2016
Reopen it as we also want to have "(beta)" string in M54 and later until we decide to take it off. See https://buganizer.corp.google.com/issues/31753396 for more details.
,
Sep 30 2016
,
Sep 30 2016
The CL to add the "(beta)" to M54 has been landed in https://codereview.chromium.org/2380383002/ (targeted to M54, will be reverted later on Tot). Not sure why it doesn't get shown here. Thus request to merge it to M54. Note adding the "(beta)" to M55 and later will be done in a separate CL since it's not necessarily to reuse the existing string and can be done in a cleaner way.
,
Sep 30 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6167a9a07466db1f025513f568643779b2d831d commit d6167a9a07466db1f025513f568643779b2d831d Author: xdai <xdai@chromium.org> Date: Fri Sep 30 20:16:28 2016 [Merge to M54] Revert "Revert "[ARC] Add "(beta)" string to Play Store."" This reverts commit d972e190a99e96c243d4d8ba421fb61a5c26d4ec. See https://codereview.chromium.org/2329063002. The "(beta)" string also needs to be merged to M54. This CL will be reverted later again once it has been merged to M54. Note the "(beta)" string also needs to go to M55 and later, but it will be done in a seperate CL since it's not necessarily to reuse the existing string and can be done in a cleaner way. BUG= 644576 TBR=xiyuan@chromium.org, dbeam@chromium.org Review URL: https://codereview.chromium.org/2380383002 . Cr-Commit-Position: refs/heads/master@{#422168} (cherry picked from commit bb3a0d028a5fc5e1c92740a5b2ea910d35f76e29) Review URL: https://codereview.chromium.org/2385853002 . Cr-Commit-Position: refs/branch-heads/2840@{#605} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d6167a9a07466db1f025513f568643779b2d831d/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/d6167a9a07466db1f025513f568643779b2d831d/chrome/browser/ui/webui/options/browser_options_handler.cc
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbba6d04c64a3918b71aee27dd5ea9b154dfcc28 commit dbba6d04c64a3918b71aee27dd5ea9b154dfcc28 Author: xdai <xdai@chromium.org> Date: Fri Sep 30 20:28:37 2016 Revert "Revert "Revert "[ARC] Add "(beta)" string to Play Store.""" This reverts commit bb3a0d028a5fc5e1c92740a5b2ea910d35f76e29. The CL to add "(beta)" string to Play Store has been merged to M54 in https://codereview.chromium.org/2385853002/. Thus revert this CL on Tot. BUG= 644576 TBR=xiyuan@chromium.org, dbeam@chromium.org Review URL: https://codereview.chromium.org/2383733003 . Cr-Commit-Position: refs/heads/master@{#422207} [modify] https://crrev.com/dbba6d04c64a3918b71aee27dd5ea9b154dfcc28/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/dbba6d04c64a3918b71aee27dd5ea9b154dfcc28/chrome/browser/ui/webui/options/browser_options_handler.cc
,
Oct 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06053d46706d6e95669e8facbf96ddbfbc9a3304 commit 06053d46706d6e95669e8facbf96ddbfbc9a3304 Author: xdai <xdai@chromium.org> Date: Sat Oct 01 02:00:29 2016 [ARC] Add "(beta)" string to Play Store until we decide to take it off. - Add (beta) at the end of header of chrome://settings section that says "Google Play Store" - Add (beta) to Play Store icon title in launcher BUG= 644576 Review-Url: https://codereview.chromium.org/2379363003 Cr-Commit-Position: refs/heads/master@{#422272} [modify] https://crrev.com/06053d46706d6e95669e8facbf96ddbfbc9a3304/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/06053d46706d6e95669e8facbf96ddbfbc9a3304/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
,
Oct 3 2016
,
Oct 4 2016
Version 54.0.2840.49/8743.54.0 cyan
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6167a9a07466db1f025513f568643779b2d831d commit d6167a9a07466db1f025513f568643779b2d831d Author: xdai <xdai@chromium.org> Date: Fri Sep 30 20:16:28 2016 [Merge to M54] Revert "Revert "[ARC] Add "(beta)" string to Play Store."" This reverts commit d972e190a99e96c243d4d8ba421fb61a5c26d4ec. See https://codereview.chromium.org/2329063002. The "(beta)" string also needs to be merged to M54. This CL will be reverted later again once it has been merged to M54. Note the "(beta)" string also needs to go to M55 and later, but it will be done in a seperate CL since it's not necessarily to reuse the existing string and can be done in a cleaner way. BUG= 644576 TBR=xiyuan@chromium.org, dbeam@chromium.org Review URL: https://codereview.chromium.org/2380383002 . Cr-Commit-Position: refs/heads/master@{#422168} (cherry picked from commit bb3a0d028a5fc5e1c92740a5b2ea910d35f76e29) Review URL: https://codereview.chromium.org/2385853002 . Cr-Commit-Position: refs/branch-heads/2840@{#605} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d6167a9a07466db1f025513f568643779b2d831d/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/d6167a9a07466db1f025513f568643779b2d831d/chrome/browser/ui/webui/options/browser_options_handler.cc |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by abodenha@chromium.org
, Sep 7 2016Status: Assigned (was: Unconfirmed)