"ManagedBookmarkServiceTest.EmptyManagedNode" is flaky |
|||||
Issue description"ManagedBookmarkServiceTest.EmptyManagedNode" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitNYW5hZ2VkQm9va21hcmtTZXJ2aWNlVGVzdC5FbXB0eU1hbmFnZWROb2RlDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90632f77da7b0e6bcdb116858edab66528f0e5a8 commit 90632f77da7b0e6bcdb116858edab66528f0e5a8 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Wed Sep 07 16:03:11 2016 Disable ManagedBookmarkServiceTest.EmptyManagedNode on Android. BUG= 644570 TBR=romax@chromium.org Review URL: https://codereview.chromium.org/2321583002 . Cr-Commit-Position: refs/heads/master@{#416944} [modify] https://crrev.com/90632f77da7b0e6bcdb116858edab66528f0e5a8/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
,
Sep 7 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd2258ce9e678e3bdbcfe814649851882dfe8118 commit dd2258ce9e678e3bdbcfe814649851882dfe8118 Author: romax <romax@chromium.org> Date: Fri Sep 09 00:53:03 2016 [Offline Pages] Fix flaky test due to actual loading of database. The flaky was due to the issue when trying to load OfflinePageModel, it would crash with SQLite Error 1802. Fixed by mock the OfflinePageModel if we're in a testing environment. BUG= 644570 Review-Url: https://codereview.chromium.org/2322793003 Cr-Commit-Position: refs/heads/master@{#417465} [modify] https://crrev.com/dd2258ce9e678e3bdbcfe814649851882dfe8118/chrome/test/BUILD.gn [modify] https://crrev.com/dd2258ce9e678e3bdbcfe814649851882dfe8118/chrome/test/base/testing_profile.cc [modify] https://crrev.com/dd2258ce9e678e3bdbcfe814649851882dfe8118/components/offline_pages/BUILD.gn [modify] https://crrev.com/dd2258ce9e678e3bdbcfe814649851882dfe8118/components/offline_pages/stub_offline_page_model.h
,
Sep 9 2016
,
Sep 9 2016
need another patch to re-enable the test. working on it.
,
Sep 13 2016
https://codereview.chromium.org/2326983003/ patch landed, marking as fixed. sorry for the delay
,
Sep 13 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vasi...@chromium.org
, Sep 7 2016Owner: romax@chromium.org