New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644563 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

OSError in closure_compilation bot's generate_gyp_files step

Project Member Reported by michae...@chromium.org, Sep 7 2016

Issue description

https://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation

Example build: http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2479

The generate_gyp_files step is failing with "No such file or directory" with a fairly inscrutable (to me) stack; find the two stacks by ctrl-f'ing for "Traceback" in https://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/2479/steps/steps/logs/stdio

Dan, can you triage this? e.g. is it an infra bug or a bug in our closure steps?

 

Comment 1 by dbeam@chromium.org, Sep 7 2016

Cc: dpranke@chromium.org
dpranke: is it time to fall back to using tools/gyp or system `gyp`?

Comment 2 by dbeam@chromium.org, Sep 7 2016

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8586881987a2c3345c16b35fc3f154ab18890a9e

commit 8586881987a2c3345c16b35fc3f154ab18890a9e
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 07 02:40:58 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/191bb2bd43d119b86f82d72a34dd65c86f0caa55 Fix GYP-based closure try bots while they continue getting ported to GN (dbeam@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 644563 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2319433002
Cr-Commit-Position: refs/heads/master@{#416829}

[modify] https://crrev.com/8586881987a2c3345c16b35fc3f154ab18890a9e/infra/config/recipes.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76cc8b1896937a0e658445ea684b998e8c6938d0

commit 76cc8b1896937a0e658445ea684b998e8c6938d0
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Sep 07 03:10:46 2016

Make third_party/closure_compiler/run_compiler more directory-agnostic

TBR=michaelpg@chromium.org
BUG= 644563 

Review URL: https://codereview.chromium.org/2318893002 .

Cr-Commit-Position: refs/heads/master@{#416831}

[modify] https://crrev.com/76cc8b1896937a0e658445ea684b998e8c6938d0/third_party/closure_compiler/run_compiler

Comment 6 by dbeam@chromium.org, Sep 7 2016

Cc: brettw@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cc1c02aecef3a718ec9f8b54b0376e07cb6cb1

commit 64cc1c02aecef3a718ec9f8b54b0376e07cb6cb1
Author: dbeam <dbeam@chromium.org>
Date: Wed Sep 07 04:02:49 2016

Change /bin/sh to /bin/bash in run_compiler to see if fixes bot issues

TBR=iannucci@chromium.org
BUG= 644563 
NO_DEPENDENCY_CHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2310413002
Cr-Commit-Position: refs/heads/master@{#416841}

[modify] https://crrev.com/64cc1c02aecef3a718ec9f8b54b0376e07cb6cb1/third_party/closure_compiler/run_compiler

Comment 8 by dbeam@chromium.org, Sep 7 2016

Components: Infra
Labels: -Pri-0 Infra-Troopers Pri-1
^ this CL fixes /try/ bots, but doesn't fix /build/ bots, as in:
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux

troopers: can anybody install bash on vm999-m1 (or check that it's installed) to see if that helps?
https://build.chromium.org/p/chromium.fyi/buildslaves/vm999-m1
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/378036a294f1ead296e09284dc83387dcacedd1f

commit 378036a294f1ead296e09284dc83387dcacedd1f
Author: dbeam <dbeam@chromium.org>
Date: Wed Sep 07 17:00:33 2016

Revert of Fix GYP-based closure try bots while they continue getting ported to GN (patchset #6 id:100001 of https://codereview.chromium.org/2315123002/ )

Reason for revert:
Hopefully reverting this fixes Closure Compilation Linux bots:
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux

They haven't been working since build/gyp_chromium was removed.  Let's convert back to using that again now that build/gyp_chromium was restored temporarily.

Original issue's description:
> Fix GYP-based closure try bots while they continue getting ported to GN
>
> R=iannucci@chromium.org
> BUG= 644563 
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/191bb2bd43d119b86f82d72a34dd65c86f0caa55

TBR=iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 644563 

Review-Url: https://codereview.chromium.org/2313403002

[modify] https://crrev.com/378036a294f1ead296e09284dc83387dcacedd1f/scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json
[modify] https://crrev.com/378036a294f1ead296e09284dc83387dcacedd1f/scripts/slave/recipes/closure_compilation.expected/closure_compilation_try.json
[modify] https://crrev.com/378036a294f1ead296e09284dc83387dcacedd1f/scripts/slave/recipes/closure_compilation.py

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3f58bbf12466f909c06171c69ea227658a9044e

commit d3f58bbf12466f909c06171c69ea227658a9044e
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 07 17:23:10 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/378036a294f1ead296e09284dc83387dcacedd1f Revert of Fix GYP-based closure try bots while they continue getting ported to GN (patchset #6 id:100001 of https://codereview.chromium.org/2315123002/ ) (dbeam@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 644563 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2323433002
Cr-Commit-Position: refs/heads/master@{#416978}

[modify] https://crrev.com/d3f58bbf12466f909c06171c69ea227658a9044e/infra/config/recipes.cfg

Components: -Infra -Infra>CQ Infra>Client>Chrome
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/7761fc03d8cb1d604f9a58af630194e7633228c4

commit 7761fc03d8cb1d604f9a58af630194e7633228c4
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 07 22:34:24 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8373aa1227eccc13db3b1c14e3699d4282b9ff1f Convert commandline to str in recipe_modules/goma (tikuta@chromium.org)
  https://crrev.com/191bb2bd43d119b86f82d72a34dd65c86f0caa55 Fix GYP-based closure try bots while they continue getting ported to GN (dbeam@chromium.org)
  https://crrev.com/11785fb7f116f51bb6442bbbe5b4096055448e57 Add counting the number of CPU's in goma module (tikuta@chromium.org)
  https://crrev.com/a29ebd495ab583c49bc8b0d1954c536e9eb48b10 goma canary; should fail when goma start failed. (yyanagisawa@chromium.org)
  https://crrev.com/383c08f181a0bd59c5c34628be1042c05a88727a WebRTC: Change Google Storage bucket for logcat dumps (kjellander@chromium.org)
  https://crrev.com/13856309f4dff0281657c5f282c5c99e55096947 chromium_android: fix dangerous default value (phajdan.jr@chromium.org)
  https://crrev.com/b9d0b44a84c7dc24fe9f69367fe8a05cfbb70d01 Delete android/perf recipe (phajdan.jr@chromium.org)
  https://crrev.com/cf533954eb5866ebdd425f81806d30264e79021c V8: Switch on MB on older branches (machenbach@chromium.org)
  https://crrev.com/1b0324b4e3dfad7455edaf416134848245331167 Convert Site Isolation Win layout tests to run with --site-per-process. (alexmos@chromium.org)
  https://crrev.com/378036a294f1ead296e09284dc83387dcacedd1f Revert of Fix GYP-based closure try bots while they continue getting ported to GN (patchset #6 id:100001 of https://codereview.chromium.org/2315123002/ ) (dbeam@chromium.org)
  https://crrev.com/f9c6f0966908f1d125ea8f519cf31b8a84aff886 DevTools: Update devtools recipe with tryserver logic (chenwilliam@chromium.org)
  https://crrev.com/ece649094b8b366432846b994819eca89d790cf9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/b6837ba5832ef4b25103a9e9680e7cd0c275ef41 [Android] Enable USB reset on perf bots. (jbudorick@chromium.org)
  https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae [Android] Set up continuous builder + trybot for cronet. (jbudorick@chromium.org)
  https://crrev.com/8e6fcd316b9f3551ec6618e39adb516accd0b0f9 Re-add perf-id and results-url. (dtu@chromium.org)
depot_tools:
  https://crrev.com/f0b0378318a0bca451dc05303ba3c0971b249103 Remove gerrit_rebase_patch_ref flag from bot_update API (andybons@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=none,634350,chromium:616035,642046,644563,644721,477150,544330,637806,584079,417518,644370,612417,642194

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2319333002

[modify] https://crrev.com/7761fc03d8cb1d604f9a58af630194e7633228c4/infra/config/recipes.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 8 2016

 Issue 644807  has been merged into this issue.
 Issue 644781  has been merged into this issue.
Status: Fixed (was: Started)

Sign in to add a comment