New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644553 link

Starred by 1 user
Status: Fixed
Owner:
jianli@chromium.org
Closed: Oct 2016
Cc:
dewittj@chromium.org
█ dim...@chromium.org
fgor...@chromium.org
█ talo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Online page may be opened when restarting Chrome with download page opened last time

Project Member Reported by jianli@chromium.org, Sep 7 2016 
Version: M54
OS: Android

What steps will reproduce the problem?
(1) Make sure the network is always connected
(2) Open a page and download it
(3) Launch the downloaded page from Download home. The downloaded page should be shown.
(4) Kill Chrome and restart it.

What is the expected output?
It is expected that the same downloaded page should be shown.

What do you see instead?
Instead, the online page is shown.


Please use labels and text to provide additional information.

Comment 1 by jianli@chromium.org, Sep 7 2016

Summary: Online page may be opened when restarting Chrome with download page opened last time (was: Online page is opened when restarting Chrome with download page opened last time)

Comment 2 by dewittj@chromium.org, Sep 23 2016

Labels: -M-54 M-55
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f62ca6f9d33e93733fccb3f3815d9554429dbb38

commit f62ca6f9d33e93733fccb3f3815d9554429dbb38
Author: jianli <jianli@chromium.org>
Date: Mon Oct 03 21:38:23 2016

Persist offline page info in a navigation entry if needed

The offline page info from extra request headers needs to be persisted
in serialized navigation entry in order for it to be restored when
Chrome restarts. Otherwise, we may be opening an online page without
this info.

The design doc for this can be found here: https://docs.google.com/document/d/1vz0a9N-9egdm3yMDYMHcNVmQHOL8Qglz54lgG4ATwhc

BUG= 644553 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2310363002
Cr-Commit-Position: refs/heads/master@{#422542}

[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/chrome/browser/BUILD.gn
[add] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/chrome/browser/android/offline_pages/offline_page_info_handler.cc
[add] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/chrome/browser/android/offline_pages/offline_page_info_handler.h
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/BUILD.gn
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/content/content_serialized_navigation_builder.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/content/content_serialized_navigation_builder_unittest.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/content/content_serialized_navigation_driver.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/content/content_serialized_navigation_driver.h
[add] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/content/extended_info_handler.h
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/core/serialized_navigation_entry.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/core/serialized_navigation_entry.h
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/core/serialized_navigation_entry_test_helper.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/core/serialized_navigation_entry_test_helper.h
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/components/sessions/core/serialized_navigation_entry_unittest.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/f62ca6f9d33e93733fccb3f3815d9554429dbb38/content/public/browser/navigation_entry.h

Comment 4 by jianli@chromium.org, Oct 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment