New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644550 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 651151

Blocking:
issue 630357
issue 647047



Sign in to add a comment

Harmony - button stroke and focus are drawn in px instead of pt

Project Member Reported by shrike@chromium.org, Sep 7 2016

Issue description

Looking at the focused secondary button from the buttons sticker sheet in the views examples, the focus ring is only 2px thick on a Retina Mac. The spec says the ring should be 2pt. The spec is not clear about the button stroke width, but I suspect it is 1pt. On a Retina Mac with width is 1px, which makes the buttons almost invisible.

The attached screenshot is from a Retina Mac, and the button stroke is px and focus ring 2px.

 
Screen Shot 2016-09-06 at 5.27.21 PM.png
7.4 KB View Download
Confirmed that this bug is also present on Windows. The attached screenshot shows 2x scaling where the focus ring is 2pts and the button stroke 1pt. At 200% they should be 4pts and 2pts.

ellyjones@ - perhaps reassign this to estade@ given that it's not a Mac-specific issue.
Screen Shot 2016-09-07 at 12.11.21 PM.png
23.5 KB View Download

Comment 2 by shrike@chromium.org, Sep 19 2016

Blocking: 647047

Comment 3 by shrike@chromium.org, Sep 19 2016

Hello ellyjones@,

I confirmed with bettes@ that the stroke should be 1pt, not 1px as specified by estade@. He is going to add the 1pt stroke specification to the button spec, but you can proceed now with fixing the stroke width.

The stroke should be 1pt on other controls as well. I will file additional bugs as needed.

Comment 4 by bettes@chromium.org, Sep 23 2016

The specs have been updated accordingly. Please assign the bug to me if there are any further questions or concerns.

Comment 5 by shrike@chromium.org, Sep 23 2016

Labels: Proj-MaterialDesign-NativeUI

Comment 6 by shrike@chromium.org, Sep 24 2016

Cc: ellyjo...@chromium.org
Owner: bettes@chromium.org
Hi bettes@,

Two questions:

1. I was saying that the button stroke needs to be 1pt and not 1px, and I think we agreed on that. But the secondary ui buttons page states that the stroke should be 1px (never scaled). At 1px the button stroke is too hard to see on a Retina display. Please clarify.

2. In the spec you mention dp - what do you mean by that exactly (and what is its relation to pts)?

Blockedon: 651151
Owner: shrike@chromium.org
Hey Jayson,

1. I'd like to continue using 1px (never scaled) for 1x and 2x. I've updated the spec with a darker alpha variable (0.20) for all ratios. Let's move forward with this and see where we land. 

2. We've resolved this. We are now using PT to denote scaled elements. PX to denote non-scaled. 

Hopefully that resolves any questions. LMK!
Labels: Proj-HarmonyControls
Status: Fixed (was: Assigned)

Sign in to add a comment