Harmony - button stroke and focus are drawn in px instead of pt |
|||||||
Issue descriptionLooking at the focused secondary button from the buttons sticker sheet in the views examples, the focus ring is only 2px thick on a Retina Mac. The spec says the ring should be 2pt. The spec is not clear about the button stroke width, but I suspect it is 1pt. On a Retina Mac with width is 1px, which makes the buttons almost invisible. The attached screenshot is from a Retina Mac, and the button stroke is px and focus ring 2px.
,
Sep 19 2016
,
Sep 19 2016
Hello ellyjones@, I confirmed with bettes@ that the stroke should be 1pt, not 1px as specified by estade@. He is going to add the 1pt stroke specification to the button spec, but you can proceed now with fixing the stroke width. The stroke should be 1pt on other controls as well. I will file additional bugs as needed.
,
Sep 23 2016
The specs have been updated accordingly. Please assign the bug to me if there are any further questions or concerns.
,
Sep 23 2016
,
Sep 24 2016
Hi bettes@, Two questions: 1. I was saying that the button stroke needs to be 1pt and not 1px, and I think we agreed on that. But the secondary ui buttons page states that the stroke should be 1px (never scaled). At 1px the button stroke is too hard to see on a Retina display. Please clarify. 2. In the spec you mention dp - what do you mean by that exactly (and what is its relation to pts)?
,
Oct 1 2016
,
Oct 3 2016
Hey Jayson, 1. I'd like to continue using 1px (never scaled) for 1x and 2x. I've updated the spec with a darker alpha variable (0.20) for all ratios. Let's move forward with this and see where we land. 2. We've resolved this. We are now using PT to denote scaled elements. PX to denote non-scaled. Hopefully that resolves any questions. LMK!
,
Oct 5 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by shrike@chromium.org
, Sep 7 201623.5 KB
23.5 KB View Download