New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644545 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Nov 2016
Cc:
█ junov@chromium.org
mlamouri@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 44872



Sign in to add a comment

Don't use blink::WebScreenInfo in content (use a content type)

Project Member Reported by ccameron@chromium.org, Sep 7 2016 
We're using blink::WebScreenInfo far more in content:: than in blink::.

It seems particularly objectionable that all of the RenderWidget::Create functions take a blink:: structure rather than a content:: structure.

The reason that this is impelling me to do something now is that I want to add a gfx::ICCProfile to all of the places where blink::WebScreenInfo is passed (e.g, to content::RenderWidget::Create and content::ResizeParams). Adding Blink support for ICC profiles only to plumb this through brings to mind the expression "there is no limit to the complexity of the wrong solution".
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5

commit 2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5
Author: ccameron <ccameron@chromium.org>
Date: Wed Sep 07 21:49:27 2016

Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG= 644545 
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2317563004
Cr-Commit-Position: refs/heads/master@{#417058}

[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_view_base_unittest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/screen_orientation/screen_orientation_browsertest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_child_frame.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_child_frame.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_guest.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_mac.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_mus.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/browser/web_contents/web_contents_view_mus.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/common/resize_params.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/common/view_messages.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/public/browser/render_widget_host.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/public/browser/screen_orientation_provider.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/public/common/BUILD.gn
[add] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/public/common/screen_info.cc
[add] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/public/common/screen_info.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/public/common/screen_orientation_values.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/public/test/render_view_test.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/devtools/render_widget_screen_metrics_emulator.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/gpu/render_widget_compositor_delegate.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/mus/compositor_mus_connection_unittest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_frame_impl.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_view_impl.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget_browsertest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget_fullscreen.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget_fullscreen.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget_fullscreen_pepper.h
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/renderer/resizing_mode_selector.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/test/fuzzer/fuzzer_support.cc
[modify] https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5/content/test/layouttest_support.cc

Comment 2 by ccameron@chromium.org, Nov 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment