Harmony [Mac] - Disabled Primary button state drawn incorrectly |
|||
Issue descriptionc#2 in Issue 642790 shows the disabled button state (light blue). c#3 of that issue shows the disabled button from the views examples - the Primary button has the same saturated blue as normal state, and the title text is gray instead of white. This bug may apply to more than just the Mac.
,
Sep 8 2016
Looks good.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17e42fe9291fd349c074d84cc6ddf994dc9a98bb commit 17e42fe9291fd349c074d84cc6ddf994dc9a98bb Author: ellyjones <ellyjones@chromium.org> Date: Thu Sep 08 12:16:38 2016 views: support disabled color for CTA buttons Disabled buttons use their usual background at 0.38a, so this change adds a new color ID for their faded background and uses it in MdTextButton::UpdateColors(). BUG= 644543 Review-Url: https://codereview.chromium.org/2315233002 Cr-Commit-Position: refs/heads/master@{#417263} [modify] https://crrev.com/17e42fe9291fd349c074d84cc6ddf994dc9a98bb/ui/views/controls/button/md_text_button.cc
,
Sep 8 2016
Fixed now.
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17e42fe9291fd349c074d84cc6ddf994dc9a98bb commit 17e42fe9291fd349c074d84cc6ddf994dc9a98bb Author: ellyjones <ellyjones@chromium.org> Date: Thu Sep 08 12:16:38 2016 views: support disabled color for CTA buttons Disabled buttons use their usual background at 0.38a, so this change adds a new color ID for their faded background and uses it in MdTextButton::UpdateColors(). BUG= 644543 Review-Url: https://codereview.chromium.org/2315233002 Cr-Commit-Position: refs/heads/master@{#417263} [modify] https://crrev.com/17e42fe9291fd349c074d84cc6ddf994dc9a98bb/ui/views/controls/button/md_text_button.cc
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8275c2644a78419c3c0a4a191314b873a1f694b9 commit 8275c2644a78419c3c0a4a191314b873a1f694b9 Author: ellyjones <ellyjones@chromium.org> Date: Thu Sep 08 19:40:31 2016 views: refactor away PlatformStyle::BackgroundColorForMdButton This change: 1) Introduces color_utils::ImplicitAlphaBlend, which does an alpha blend using the alpha of the foreground color; 2) Introduces a NativeTheme color ID for the shading of a pressed button; 3) Uses ImplicitAlphaBlend to blend that shade, instead of calling into PlatformStyle; 4) Deletes PlatformStyle::BackgroundColorForMdButton BUG= 644543 Review-Url: https://codereview.chromium.org/2319313003 Cr-Commit-Position: refs/heads/master@{#417366} [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/gfx/color_utils.cc [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/gfx/color_utils.h [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/native_theme/common_theme.cc [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/native_theme/native_theme.h [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/native_theme/native_theme_dark_aura.cc [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/native_theme/native_theme_mac.mm [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/views/style/platform_style.cc [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/views/style/platform_style.h [modify] https://crrev.com/8275c2644a78419c3c0a4a191314b873a1f694b9/ui/views/style/platform_style_mac.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, Sep 7 201617.8 KB
17.8 KB View Download