Use-count css clip on fixed-position elements |
|||||
Issue descriptionWe already have UseCounter::ClipCssOfPositionedElement, but should strengthen it to just fixed-position. That is the only case in which the clipping disagrees with containing block.
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b9233a9d980ab703c719682f3700b28a75cc5f0 commit 6b9233a9d980ab703c719682f3700b28a75cc5f0 Author: chrishtr <chrishtr@chromium.org> Date: Fri Sep 09 07:27:58 2016 Add a use counter of css clip of fixed-pos elements. BUG= 644510 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2326773002 Cr-Commit-Position: refs/heads/master@{#417524} [modify] https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp [modify] https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0/tools/metrics/histograms/histograms.xml
,
Sep 9 2016
,
Sep 10 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b31629ad37bb5946eb197ddd124bc188e1867878 commit b31629ad37bb5946eb197ddd124bc188e1867878 Author: Chris Harrelson <chrishtr@chromium.org> Date: Sat Sep 10 20:58:47 2016 Add a use counter of css clip of fixed-pos elements. BUG= 644510 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2326773002 Cr-Commit-Position: refs/heads/master@{#417524} (cherry picked from commit 6b9233a9d980ab703c719682f3700b28a75cc5f0) Review URL: https://codereview.chromium.org/2327333003 . Cr-Commit-Position: refs/branch-heads/2840@{#291} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b31629ad37bb5946eb197ddd124bc188e1867878/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/b31629ad37bb5946eb197ddd124bc188e1867878/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp [modify] https://crrev.com/b31629ad37bb5946eb197ddd124bc188e1867878/tools/metrics/histograms/histograms.xml
,
Sep 10 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b31629ad37bb5946eb197ddd124bc188e1867878 commit b31629ad37bb5946eb197ddd124bc188e1867878 Author: Chris Harrelson <chrishtr@chromium.org> Date: Sat Sep 10 20:58:47 2016 Add a use counter of css clip of fixed-pos elements. BUG= 644510 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2326773002 Cr-Commit-Position: refs/heads/master@{#417524} (cherry picked from commit 6b9233a9d980ab703c719682f3700b28a75cc5f0) Review URL: https://codereview.chromium.org/2327333003 . Cr-Commit-Position: refs/branch-heads/2840@{#291} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b31629ad37bb5946eb197ddd124bc188e1867878/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/b31629ad37bb5946eb197ddd124bc188e1867878/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp [modify] https://crrev.com/b31629ad37bb5946eb197ddd124bc188e1867878/tools/metrics/histograms/histograms.xml |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by chrishtr@chromium.org
, Sep 8 2016