New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644494 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Merge Bluetooth socket to M53

Project Member Reported by puthik@chromium.org, Sep 6 2016

Issue description

Request for merge the patch below to m-53

This should make android.bluetooth cts pass. Note that the functionality is still incomplete but cts won't test that. This still fail the cts verifier.

http://crrev.com/2166143002

arc: bluetooth: Implement socket opening

We cannot open BT sockets in side the container due to linux
kernel disallowing socket() calls to BT subsystem in a net
namespace. We avoid this by tunneling the actual socket()
call to outside the container thusly.

BUG=

Committed: https://crrev.com/f6ef3d8451163369bd5c8b0846b68edf75cb0c74
Cr-Commit-Position: refs/heads/master@{#406951}
  
 
Cc: dmitrygr@chromium.org snanda@chromium.org
+snanda, dmitrygr
Components: OS>Systems>Bluetooth

Comment 3 by dimu@chromium.org, Sep 7 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.
Cc: keta...@chromium.org
Owner: bhthompson@chromium.org
Ask bernie for manual review.

This patch only touch the component/arc.
Labels: -Hotlist-Merge-review -Merge-Review-53 Merge-Approved-53
Owner: puthik@chromium.org
It also seems this should be in 54 so this has been around a while, if this is necessary for CTS we should put it in. 
Owner: st...@chromium.org
Assign to steel for merge
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 7 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed755265577cd13c9957cbabd7d9afe29d59c8e2

commit ed755265577cd13c9957cbabd7d9afe29d59c8e2
Author: Rahul Chaturvedi <rkc@google.com>
Date: Wed Sep 07 23:46:53 2016

arc: bluetooth: Implement socket opening

We cannot open BT sockets in side the container due to linux
kernel disallowing socket() calls to BT subsystem in a net
namespace. We avoid this by tunneling the actual socket()
call to outside the container thusly.

BUG= 644494 

Review-Url: https://codereview.chromium.org/2166143002
Cr-Commit-Position: refs/heads/master@{#406951}
(cherry picked from commit f6ef3d8451163369bd5c8b0846b68edf75cb0c74)

Review URL: https://codereview.chromium.org/2319953002 .

Cr-Commit-Position: refs/branch-heads/2785@{#846}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/ed755265577cd13c9957cbabd7d9afe29d59c8e2/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/ed755265577cd13c9957cbabd7d9afe29d59c8e2/components/arc/bluetooth/arc_bluetooth_bridge.h
[modify] https://crrev.com/ed755265577cd13c9957cbabd7d9afe29d59c8e2/components/arc/common/bluetooth.mojom

Comment 8 by st...@chromium.org, Sep 7 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Cc: r...@chromium.org
Cc: -st...@chromium.org
Owner: r...@chromium.org

Sign in to add a comment