New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644489 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Clicking on a link triggers a phone call (to a mis-interpreted number)

Project Member Reported by pkl@chromium.org, Sep 6 2016

Issue description

App Version (from "Chrome Settings > About Chrome"): 55.0.2846.0 canary
iOS Version: iOS 10 beta
Device: iPhone 5S

Steps to reproduce: 
Visit this page: http://www.nhc.noaa.gov/refresh/graphics_at4+shtml/175321.shtml?tswind120#contents
Look for the boxed section of "Hurricane Wind Speed Probability" section just above the big map. There's a bunch of links "0 12 24 36 48 ...".
Tap on one of the links, e.g. 12

Observed behavior: 
A phone number is detected and a prompt to call 0 12 24 36 48 60 72 84 is detected.

Expected behavior: 
Navigate to the link.

Frequency: 
100%

Additional comments: 
Note that this works on iOS 9 device
 

Comment 1 by pkl@chromium.org, Sep 6 2016

Screen Shot 2016-09-06 at 3.31.36 PM.png
190 KB View Download
Screen Shot 2016-09-06 at 3.31.41 PM.png
163 KB View Download
We should file a radar for this. If false positives are frequent me should even consider disabling phone numbers detection.

Comment 3 by pkl@chromium.org, Sep 20 2016

Ping. Any update on this? Should we file a radar?
Cc: vkarut...@chromium.org
Owner: vkarut...@chromium.org
I can no longer reproduce. It's possible this was fixed in iOS10 GM.

vkaruturi@, please try to reproduce.
Owner: michaeldo@chromium.org
I can still reproduce this on iOS10 GM and iOS10.1 beta build as well.
Also note, this works fine in M53, reproduced only in M54 and M55 versions.

Let us know if you need more info.
Also works fine in Safari and Firefox.
Labels: Hotlist-ConOps
We've started seeing this issue from user feedback and App store comment. 
I can reproduce it on "www.kanyetothe.com/forum/index.php?topic=56310.48402".
http://feedback/#/Report/20735716558
  

Comment 8 by pkl@chromium.org, Oct 25 2016

Cc: mard...@chromium.org cma...@chromium.org
+mardini to help decide if we want to include any changes in this area in a M54 Refresh release. Or for M55.

Comment 9 by cma...@chromium.org, Oct 25 2016

michaeldo@, what is the current Bling vs. Safari triggering logic? 
We technically use the same logic, we enabled this on WKWebView using a flag. It appears that the WebKit implementation in WKWebView is not identical to that in Safari.

I validated this and it is broken in Chrome and works in Safari. I am currently downloading Xcode 8.1 so I can test with 10.1 to see if Apple has fixed this or not.

If not we should file a radar and webkit bug and decide if we should pull this feature for now since it breaks real websites.

If iOS 10.1 fixes this issue, I suggest we leave it enabled.
There is another real world example from the user:
http://www.kurnik.pl/misc/s.html
This is still broken in iOS 10.1 and WKWebView's behavior is not consistent with Safari's behavior.

cmasso@ mardini@,
I can file a radar and webkit bug, but should we revert Phone Number detection for now? If we do, we should test flight number and calendar event detection in more depth to ensure parity with Safari.
I have filed a radar and webkit bug for this issue.

radar/28945517
https://bugs.webkit.org/show_bug.cgi?id=163989

Comment 14 by pkl@chromium.org, Oct 26 2016

I think we should revert the feature to un-break users.

I also believe we should revert the feature. I also agree with  michaeldo@ to make sure we do not also break the users with flight number and calendar event detection currently in M55 (if I am not wrong).
Cc: linds...@chromium.org
Agree with revert and thoroughly testing flight number and calendar event detection.

Should this bug be marked now as external dependency?
Cc: pinkerton@chromium.org
+ Pinkerton (FYI)
Sounds good, we'll test for flight and calendar events once the revert is in.
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330fef1531d57e4b77bdc0edf63e6bdf3218691e

commit 330fef1531d57e4b77bdc0edf63e6bdf3218691e
Author: michaeldo <michaeldo@chromium.org>
Date: Wed Oct 26 17:06:39 2016

Remove Phone Number data detection.

BUG= 644489 

Review-Url: https://codereview.chromium.org/2456533002
Cr-Commit-Position: refs/heads/master@{#427725}

[modify] https://crrev.com/330fef1531d57e4b77bdc0edf63e6bdf3218691e/ios/web/web_state/ui/wk_web_view_configuration_provider.mm

Status: Fixed (was: Assigned)
Issue fixed on chrome canary version 56.0.2903.0 on iPhone 5 with iOS 10.0.2 and iPhone 7 with iOS 10.0.3.  When tapped on the links "0 12 24 36 48 ..." under Hurricane Wind Speed Probability" section, it is directed to a new page.  Looks good.
Status: Verified (was: Fixed)
Hi Micheal,
Is this fix going into the respin for M54? It is listed here:
https://docs.google.com/spreadsheets/d/13WgiImuVLs_NFphzYnMgB2e6Wy0ibAI7K9bl-q0LHU0/edit#gid=19002889&vpid=A1
If so can you please merge this fix to 54 and mark it as RBS?
Thanks,


Labels: ReleaseBlock-Stable
Hi Lindsay,

Yes it will go into M54 respin, I will work to merge this change in asap.
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 31 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e92ffeaea3e3b386247d4061c5a2a6bbf4446f2

commit 5e92ffeaea3e3b386247d4061c5a2a6bbf4446f2
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Oct 31 20:30:31 2016

Remove Phone Number data detection.

BUG= 644489 

Review-Url: https://codereview.chromium.org/2456533002
Cr-Commit-Position: refs/heads/master@{#427725}
(cherry picked from commit 330fef1531d57e4b77bdc0edf63e6bdf3218691e)

Review URL: https://codereview.chromium.org/2470513002 .

Cr-Commit-Position: refs/branch-heads/2840@{#809}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/5e92ffeaea3e3b386247d4061c5a2a6bbf4446f2/ios/web/web_state/ui/wk_web_view_configuration_provider.mm

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 31 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ba2ed3c1fc3ddb0f923cb1c24facdfe78ba746

commit 98ba2ed3c1fc3ddb0f923cb1c24facdfe78ba746
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Oct 31 20:31:36 2016

Remove Phone Number data detection.

BUG= 644489 

Review-Url: https://codereview.chromium.org/2456533002
Cr-Commit-Position: refs/heads/master@{#427725}
(cherry picked from commit 330fef1531d57e4b77bdc0edf63e6bdf3218691e)

Review URL: https://codereview.chromium.org/2462213003 .

Cr-Commit-Position: refs/branch-heads/2883@{#395}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/98ba2ed3c1fc3ddb0f923cb1c24facdfe78ba746/ios/web/web_state/ui/wk_web_view_configuration_provider.mm

Comment 27 by pkl@chromium.org, Oct 31 2016

Cc: michaeldo@chromium.org jasonkliu@chromium.org
 Issue 660508  has been merged into this issue.
Labels: -Restrict-View-Google
Verified in 56.0.2904.0 canary, iPhone air iOS 10.0.1
Verified on chrome dev version 54.0.2840.91 on iPhone 6 with iOS 10.0.2, iPhone 6 plus and iPad air with iOS 10.1.  When tapped on the links "0 12 24 36 48 ..." under Hurricane Wind Speed Probability" section, it is directed to a new page.  Looks good
Verified on chrome beta version 55.0.2883.42 on iPhone 6 plus with iOS 10.2 and iPad4 with iOS 10.1.  When tapped on the links "0 12 24 36 48 ..." under Hurricane Wind Speed Probability" section, it is directed to a new page.  Looks good

Sign in to add a comment