Canceled downloads appear in the download manager |
|||||
Issue descriptionVersion: Clank ToT If Download Home is open when a download is canceled, it appears in the list when it shouldn't. Closing and reopening the UI makes the download disappear as expected. We need to change how the native side DownloadManagerService decides to alert the UI, which means explicitly checking for the completed state instead of the done state, which can also mean canceled.
,
Sep 7 2016
Going to request a merge on this right-off because the fix is trivial.
,
Sep 7 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 7 2016
[Bulk edit] This issue has been approved for a merge to M54 branch 2840. Please try to complete the merge by tomorrow at 5 PM PT if at all possible. If this has already been merged and this message is in error, please remove the label Merge-Approved-54. Cheers, Alex
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a870e78d30e8b8cfc2743a8f7111b6e32ebff52b commit a870e78d30e8b8cfc2743a8f7111b6e32ebff52b Author: dfalcantara@chromium.org <dfalcantara@chromium.org> Date: Wed Sep 07 17:22:46 2016 [Download Home] Don't show canceled downloads Explicitly check for a "completed" state. BUG=616324, 644485 TBR=qinmin Review URL: https://codereview.chromium.org/2317193002 . Review-Url: https://codereview.chromium.org/2314223003 Cr-Original-Commit-Position: refs/heads/master@{#416791} Cr-Commit-Position: refs/branch-heads/2840@{#210} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a870e78d30e8b8cfc2743a8f7111b6e32ebff52b/chrome/browser/android/download/download_manager_service.cc
,
Sep 7 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a870e78d30e8b8cfc2743a8f7111b6e32ebff52b commit a870e78d30e8b8cfc2743a8f7111b6e32ebff52b Author: dfalcantara@chromium.org <dfalcantara@chromium.org> Date: Wed Sep 07 17:22:46 2016 [Download Home] Don't show canceled downloads Explicitly check for a "completed" state. BUG=616324, 644485 TBR=qinmin Review URL: https://codereview.chromium.org/2317193002 . Review-Url: https://codereview.chromium.org/2314223003 Cr-Original-Commit-Position: refs/heads/master@{#416791} Cr-Commit-Position: refs/branch-heads/2840@{#210} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a870e78d30e8b8cfc2743a8f7111b6e32ebff52b/chrome/browser/android/download/download_manager_service.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 7 2016