New issue
Advanced search Search tips

Issue 644483 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Threading error in Geolocation Service.

Project Member Reported by khushals...@chromium.org, Sep 6 2016

Issue description

Not sure if this was already filed CJ, I'm seeing an error on shutdown on the engine. Looks like the weakptrs for the EngineGeolocationFeature are not being invalidated on the correct thread,

[23894:23894:0906/151656:FATAL:weak_ptr.cc(20)] Check failed: sequence_checker_.CalledOnValidSequence() || HasOneRef(). WeakPtrs must be invalidated on the same sequenced thread.
#0 0x7fd27c1aed5e base::debug::StackTrace::StackTrace()
#1 0x7fd27c2159cf logging::LogMessage::~LogMessage()
#2 0x7fd27c22db68 base::internal::WeakReference::Flag::Invalidate()
#3 0x7fd27c22ded4 base::internal::WeakReferenceOwner::Invalidate()
#4 0x7fd27c22de89 base::internal::WeakReferenceOwner::~WeakReferenceOwner()
#5 0x00000043babd base::WeakPtrFactory<>::~WeakPtrFactory()
#6 0x00000048cefc blimp::engine::EngineGeolocationFeature::~EngineGeolocationFeature()
#7 0x0000004c7d57 blimp::engine::BlimpEngineSession::~BlimpEngineSession()
#8 0x0000004c7eb9 blimp::engine::BlimpEngineSession::~BlimpEngineSession()
#9 0x000000428d5f std::default_delete<>::operator()()
#10 0x00000042864c std::unique_ptr<>::reset()
#11 0x00000042819d blimp::engine::BlimpBrowserMainParts::PostMainMessageLoopRun()
#12 0x7fd278e38ac8 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#13 0x7fd278e427a3 content::BrowserMainRunnerImpl::Shutdown()
#14 0x7fd278e32665 content::BrowserMain()
#15 0x7fd27aa415d6 content::RunNamedProcessTypeMain()
#16 0x7fd27aa438c2 content::ContentMainRunnerImpl::Run()
#17 0x7fd27aa40692 content::ContentMain()
#18 0x000000427d25 main
#19 0x7fd26f923f45 __libc_start_main
#20 0x000000427bf5 <unknown>

 
Labels: -Pri-3 M-55 Pri-2
This is still flaky and happening. Would be awesome if you had time to look at this.
Components: Mobile>Blimp>Engine
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b44beefc9298186e5e1e27d0c2f90244bcbfef6

commit 4b44beefc9298186e5e1e27d0c2f90244bcbfef6
Author: lethalantidote <lethalantidote@chromium.org>
Date: Sat Oct 08 00:49:30 2016

Makes use of EngineGeolocationFeature weak_ptr threadsafe.

There was an issue where a weak_ptr to EngineGeolocationFeature
was being invalidated while another thread was accessing it. This
CL corrects this issue.

BUG= 644483 

Review-Url: https://codereview.chromium.org/2328453003
Cr-Commit-Position: refs/heads/master@{#424029}

[modify] https://crrev.com/4b44beefc9298186e5e1e27d0c2f90244bcbfef6/blimp/engine/feature/geolocation/blimp_location_provider.cc
[modify] https://crrev.com/4b44beefc9298186e5e1e27d0c2f90244bcbfef6/blimp/engine/feature/geolocation/blimp_location_provider.h
[modify] https://crrev.com/4b44beefc9298186e5e1e27d0c2f90244bcbfef6/blimp/engine/feature/geolocation/blimp_location_provider_unittest.cc
[modify] https://crrev.com/4b44beefc9298186e5e1e27d0c2f90244bcbfef6/blimp/engine/feature/geolocation/engine_geolocation_feature.cc
[modify] https://crrev.com/4b44beefc9298186e5e1e27d0c2f90244bcbfef6/blimp/engine/feature/geolocation/engine_geolocation_feature.h
[modify] https://crrev.com/4b44beefc9298186e5e1e27d0c2f90244bcbfef6/blimp/engine/feature/geolocation/engine_geolocation_feature_unittest.cc
[modify] https://crrev.com/4b44beefc9298186e5e1e27d0c2f90244bcbfef6/blimp/engine/feature/geolocation/mock_blimp_location_provider_delegate.h

Status: Fixed (was: Started)
Issue 647054 has been merged into this issue.
Labels: Archive-Blimp

Sign in to add a comment