[Offline Pages] Download notification is completed upon a canceled attempt due to network connectivity issue or transition to foreground |
||||||
Issue descriptionI switched to airplane mode directly after offliner attempt started. The attempt was canceled as expected but the notification thought the operation was complete even though it was subject to retry (and did in fact succeed later). I think we should not be calling NotifyCompleted for FOREGROUND_CANCELED or PRERENDERING_CANCELED case in OfflinerDoneCallback. We should wait to call it when the attempts expired and request is removed from the queue. Or else we need to introduce some intermediate status if we want to reveal the attempt.
,
Sep 7 2016
Right, some cases of current operation being "canceled" rather than the attempt completing as "failed". We will retry in these canceled cases currently.
,
Sep 7 2016
If this can happen in M54 (do we have any scenario in M54 that actually tries more than once?) then it'd be M54 bug.
,
Sep 7 2016
,
Sep 7 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9c01aee8aef23aaa838c71fc2df65254b344131 commit f9c01aee8aef23aaa838c71fc2df65254b344131 Author: dougarnett <dougarnett@chromium.org> Date: Thu Sep 08 17:38:16 2016 [Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_CANCELED or PRERENDERING_CANCELED and subject to retry. BUG= 644444 Review-Url: https://codereview.chromium.org/2326593002 Cr-Commit-Position: refs/heads/master@{#417328} [modify] https://crrev.com/f9c01aee8aef23aaa838c71fc2df65254b344131/components/offline_pages/background/request_coordinator.cc
,
Sep 8 2016
Fixed in origin
,
Sep 8 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a47a78adea9f959e5df0ea4b21279abc78055f commit e6a47a78adea9f959e5df0ea4b21279abc78055f Author: Pete Williamson <petewil@chromium.org> Date: Thu Sep 08 18:00:15 2016 [Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_CANCELED or PRERENDERING_CANCELED and subject to retry. BUG= 644444 Review-Url: https://codereview.chromium.org/2326593002 Cr-Commit-Position: refs/heads/master@{#417328} (cherry picked from commit f9c01aee8aef23aaa838c71fc2df65254b344131) Review URL: https://codereview.chromium.org/2324883002 . Cr-Commit-Position: refs/branch-heads/2840@{#236} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/e6a47a78adea9f959e5df0ea4b21279abc78055f/components/offline_pages/background/request_coordinator.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a47a78adea9f959e5df0ea4b21279abc78055f commit e6a47a78adea9f959e5df0ea4b21279abc78055f Author: Pete Williamson <petewil@chromium.org> Date: Thu Sep 08 18:00:15 2016 [Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_CANCELED or PRERENDERING_CANCELED and subject to retry. BUG= 644444 Review-Url: https://codereview.chromium.org/2326593002 Cr-Commit-Position: refs/heads/master@{#417328} (cherry picked from commit f9c01aee8aef23aaa838c71fc2df65254b344131) Review URL: https://codereview.chromium.org/2324883002 . Cr-Commit-Position: refs/branch-heads/2840@{#236} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/e6a47a78adea9f959e5df0ea4b21279abc78055f/components/offline_pages/background/request_coordinator.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fgor...@chromium.org
, Sep 6 2016