New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 644440 link

Starred by 1 user
Status: Fixed
Owner:
█ nyquist@chromium.org
Traveling - Back 2/6
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 597756



Sign in to add a comment

Remove main crashers for running blimp in tabbed mode

Project Member Reported by nyquist@chromium.org, Sep 6 2016 
Currently there are some issues with starting and closing tabs when running blimp in tabbed mode.

For one, the Tab should not DCHECK the blimp_contents it gets back from the BlimpClientContext, but instead bail out if its nullptr.

Also, since the client now controls tabs, there might be messages coming in from the engine after a render widget has been removed, so we should not crash on that.

There are also some more places to ensure that we cleanup the RenderWidgetDelegate when closing BlimpContents, etc.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9189c7232659395664e5fc99c62853abd9ffa061

commit 9189c7232659395664e5fc99c62853abd9ffa061
Author: nyquist <nyquist@chromium.org>
Date: Wed Sep 07 08:06:58 2016

Fix crashers and issues when rendering blimp in tabs

- Remove the limitation where size messages was never re-sent if the
  values did not change. However, when creating new BlimpContents, we
  need to re-send the size to get the engine to know the correct size.
- Do a graceful bail out for when BlimpContents are not created. This
  is required when there already is a BlimpContents created, but not
  yet destroyed. This makes WebContents-based and BlimpContents based
  tabs seamless.
- Messages from the engine might arrive after a BlimpContents has been
  deleted, so those messages should be ignored.

BUG= 644440 

Review-Url: https://codereview.chromium.org/2313133002
Cr-Commit-Position: refs/heads/master@{#416880}

[modify] https://crrev.com/9189c7232659395664e5fc99c62853abd9ffa061/blimp/client/core/contents/blimp_navigation_controller_impl.cc
[modify] https://crrev.com/9189c7232659395664e5fc99c62853abd9ffa061/blimp/client/core/contents/tab_control_feature.cc
[modify] https://crrev.com/9189c7232659395664e5fc99c62853abd9ffa061/blimp/client/core/contents/tab_control_feature_unittest.cc
[modify] https://crrev.com/9189c7232659395664e5fc99c62853abd9ffa061/blimp/client/core/render_widget/render_widget_feature.cc
[modify] https://crrev.com/9189c7232659395664e5fc99c62853abd9ffa061/chrome/browser/android/tab_android.cc

Comment 2 by dtrainor@chromium.org, Sep 7 2016

Status: Fixed (was: Untriaged)

Comment 3 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment