Make test expectations linter run over flag expectation files too |
||
Issue descriptionOur flag-specific expectations file for spv2 (FlagExpectations/enable-slimming-paint-v2) doesn't get the linter run over it on upload which can lead to duplicate entries going unnoticed and causing silent failures. We should make the linter run over flag expectations too, which would have caught a bug in https://codereview.chromium.org/2314103002.
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f78775a0c38ec507ee61f5e062151c3108c7a1fc commit f78775a0c38ec507ee61f5e062151c3108c7a1fc Author: pdr <pdr@chromium.org> Date: Fri Oct 07 19:34:47 2016 Fix syntax of FlagExpectations/site-per-process In preparation for linting all flag expectations files, this patch fixes the syntax of FlagExpectations/site-per-process. BUG= 644435 Review-Url: https://codereview.chromium.org/2396303002 Cr-Commit-Position: refs/heads/master@{#423932} [modify] https://crrev.com/f78775a0c38ec507ee61f5e062151c3108c7a1fc/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0cb91ee9abbd92a11248c4d9f0bd550e6ae773f commit a0cb91ee9abbd92a11248c4d9f0bd550e6ae773f Author: pdr <pdr@chromium.org> Date: Fri Oct 07 19:39:25 2016 Fix syntax of FlagExpectations/enable-slimming-paint-v2 In preparation for linting all flag expectations files, this patch fixes the syntax of FlagExpectations/enable-slimming-paint-v2. BUG= 644435 Review-Url: https://codereview.chromium.org/2398413003 Cr-Commit-Position: refs/heads/master@{#423933} [modify] https://crrev.com/a0cb91ee9abbd92a11248c4d9f0bd550e6ae773f/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cefa9cee91c95bcc5f00740c2fb495fa452ad0c commit 6cefa9cee91c95bcc5f00740c2fb495fa452ad0c Author: pdr <pdr@chromium.org> Date: Fri Oct 07 19:40:21 2016 Fix syntax of FlagExpectations/root-layer-scrolls In preparation for linting all flag expectations files, this patch fixes the syntax of FlagExpectations/root-layer-scrolls. BUG= 644435 Review-Url: https://codereview.chromium.org/2402013002 Cr-Commit-Position: refs/heads/master@{#423934} [modify] https://crrev.com/6cefa9cee91c95bcc5f00740c2fb495fa452ad0c/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/044de20a8ade9186461d790454431ca66a54b044 commit 044de20a8ade9186461d790454431ca66a54b044 Author: pdr <pdr@chromium.org> Date: Fri Oct 07 19:45:48 2016 Fix syntax of FlagExpectations/enable-browser-side-navigation In preparation for linting all flag expectations files, this patch fixes the syntax of FlagExpectations/enable-browser-side-navigation. BUG= 644435 Review-Url: https://codereview.chromium.org/2400663005 Cr-Commit-Position: refs/heads/master@{#423940} [modify] https://crrev.com/044de20a8ade9186461d790454431ca66a54b044/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76b5bff8f195819fe17b2e0f773d0a5b427c75f5 commit 76b5bff8f195819fe17b2e0f773d0a5b427c75f5 Author: pdr <pdr@chromium.org> Date: Fri Oct 07 21:56:50 2016 Fix syntax of enable-blink-features=slimmingPaintInvalidation In preparation for linting all flag expectations files, this patch fixes the syntax of FlagExpectations/enable-blink-features=slimmingPaintInvalidation. BUG= 644435 Review-Url: https://codereview.chromium.org/2406513002 Cr-Commit-Position: refs/heads/master@{#423976} [modify] https://crrev.com/76b5bff8f195819fe17b2e0f773d0a5b427c75f5/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=slimmingPaintInvalidation
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/788f3061e6fb55c35fdccfc42085a1b612b99223 commit 788f3061e6fb55c35fdccfc42085a1b612b99223 Author: pdr <pdr@chromium.org> Date: Fri Oct 07 23:35:44 2016 Update lint-test-expectations to check on FlagExpectations lint-test-expectations is the python script used to lint all test expectations files, including TestExpectations, NeverFixTests, virtual test suites, etc. This patch updates the linter to also check for flag-specific expectations in the FlagExpectations/ directory. BUG= 644435 Review-Url: https://codereview.chromium.org/2397723006 Cr-Commit-Position: refs/heads/master@{#424014} [modify] https://crrev.com/788f3061e6fb55c35fdccfc42085a1b612b99223/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py [modify] https://crrev.com/788f3061e6fb55c35fdccfc42085a1b612b99223/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py [modify] https://crrev.com/788f3061e6fb55c35fdccfc42085a1b612b99223/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py [modify] https://crrev.com/788f3061e6fb55c35fdccfc42085a1b612b99223/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
,
Oct 8 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by pdr@chromium.org
, Oct 4 2016Labels: -Pri-3 Pri-2