New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 644432 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Add session/device details to chromeosInfoPrivate.

Project Member Reported by st...@chromium.org, Sep 6 2016

Issue description

Apps can need to know certain details about their session and or device that currently are being provided from onLaunched (https://developer.chrome.com/apps/app_runtime#event-onLaunched). Some examples are is kiosk mode status, play store status, etc.

Having these available from onLaunched is an issue for several reasons,
a.) Some of these keys can only be shown to certain apps for security reasons, hence it is complicated to only add them for some apps.
b.) Some apps don't get an onLaunched at all (demo app launched from public sessions)
c.) The info can be missing/incorrect for certain apps - for example secondary apps launched by a primary kiosk app, will not have this key set correctly.

To fix this, we are adding the following properties to chromeosInfoPrivate (note: this will be renamed to chromeosInfo and will be available to all kiosk apps with crbug.com/629931).

. sessionType ("kiosk", "public session", "normal")
. playStoreStatus ("not available", "available", "enabled")

These will be properties that will be retrievable by using the chromeosInfo[Private].get() call.

 

Comment 1 by st...@chromium.org, Sep 6 2016

Components: Platform>Apps>API
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab

commit dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab
Author: steel <steel@chromium.org>
Date: Thu Sep 08 03:54:07 2016

Add sessionType and playStoreStatus to chromeosInfoPrivate.

Add properties for getting the session type and the playstore status to
chromeosInfoPrivate. This CL also whitelists the GetHelp and the Demo
apps to be able to use the API.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org
BUG= 644432 ,644446

Review-Url: https://codereview.chromium.org/2314313002
Cr-Commit-Position: refs/heads/master@{#417182}

[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/common/extensions/api/chromeos_info_private.json
[rename] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/basic/background.js
[rename] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/basic/manifest.json
[add] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
[copy] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/extended/manifest.json

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab

commit dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab
Author: steel <steel@chromium.org>
Date: Thu Sep 08 03:54:07 2016

Add sessionType and playStoreStatus to chromeosInfoPrivate.

Add properties for getting the session type and the playstore status to
chromeosInfoPrivate. This CL also whitelists the GetHelp and the Demo
apps to be able to use the API.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org
BUG= 644432 ,644446

Review-Url: https://codereview.chromium.org/2314313002
Cr-Commit-Position: refs/heads/master@{#417182}

[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/common/extensions/api/chromeos_info_private.json
[rename] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/basic/background.js
[rename] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/basic/manifest.json
[add] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
[copy] https://crrev.com/dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab/chrome/test/data/extensions/api_test/chromeos_info_private/extended/manifest.json

Comment 4 by oka@chromium.org, Sep 9 2016

Cc: oka@chromium.org

Comment 5 by st...@chromium.org, Sep 12 2016

Labels: -merge-merged-2854 Merge-Request-54
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eced24d28d5c654f309be4232f885c2f38bbf7d

commit 6eced24d28d5c654f309be4232f885c2f38bbf7d
Author: Rahul Chaturvedi <rkc@google.com>
Date: Mon Sep 12 22:54:48 2016

Add sessionType and playStoreStatus to chromeosInfoPrivate.

Add properties for getting the session type and the playstore status to
chromeosInfoPrivate. This CL also whitelists the GetHelp and the Demo
apps to be able to use the API.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org
BUG= 644432 ,644446

Review-Url: https://codereview.chromium.org/2314313002
Cr-Commit-Position: refs/heads/master@{#417182}
(cherry picked from commit dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab)

Review URL: https://codereview.chromium.org/2332193002 .

Cr-Commit-Position: refs/branch-heads/2840@{#317}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/common/extensions/api/chromeos_info_private.json
[rename] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/basic/background.js
[rename] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/basic/manifest.json
[add] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
[copy] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/extended/manifest.json

Comment 7 by st...@chromium.org, Sep 12 2016

Status: Fixed (was: Started)

Comment 8 by dimu@chromium.org, Sep 13 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 17 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by st...@chromium.org, Sep 17 2016

Labels: -Merge-Approved-54
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eced24d28d5c654f309be4232f885c2f38bbf7d

commit 6eced24d28d5c654f309be4232f885c2f38bbf7d
Author: Rahul Chaturvedi <rkc@google.com>
Date: Mon Sep 12 22:54:48 2016

Add sessionType and playStoreStatus to chromeosInfoPrivate.

Add properties for getting the session type and the playstore status to
chromeosInfoPrivate. This CL also whitelists the GetHelp and the Demo
apps to be able to use the API.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org
BUG= 644432 ,644446

Review-Url: https://codereview.chromium.org/2314313002
Cr-Commit-Position: refs/heads/master@{#417182}
(cherry picked from commit dd8446dec9f27e7d46dbc607f6d16e8b7fbab8ab)

Review URL: https://codereview.chromium.org/2332193002 .

Cr-Commit-Position: refs/branch-heads/2840@{#317}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/common/extensions/api/chromeos_info_private.json
[rename] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/basic/background.js
[rename] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/basic/manifest.json
[add] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
[copy] https://crrev.com/6eced24d28d5c654f309be4232f885c2f38bbf7d/chrome/test/data/extensions/api_test/chromeos_info_private/extended/manifest.json

Owner: r...@chromium.org

Comment 13 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 14 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 15 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 17 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment